Add mg_crc16(), make PPP use it

test/ppp_test.c

@@ -61,6 +61,17 @@ static void *ppp_payload(uint8_t *frame) {
   return (struct ppp *) ((struct hdlc_ *) frame + 1) + 1;
 }
 
+static void test_fcs(void) {
+  struct mg_tcpip_if ifp;
+  uint8_t frame[] = {0xff, 0x03, 0x00, 0x21, 1, 2, 3, 4, 0, 0};
+  uint8_t fcs[] = {0xae, 0x77};
+  init_if(&ifp, MG_TCPIP_L2_PPP);
+  // PPP trailer stores the FCS bytes in the proper order
+  ASSERT(mg_l2_ppp_trailer(&ifp, 4, frame + sizeof(frame) - sizeof(fcs)) ==
+         sizeof(frame));
+  ASSERT(memcmp(frame + sizeof(frame) - sizeof(fcs), fcs, sizeof(fcs)) == 0);
+}
+
 static size_t mk_pppoe_disc(uint8_t *buf, uint8_t code, uint16_t id,
                             const void *payload, size_t len) {
   struct eth *eth = (struct eth *) buf;
@@ -385,6 +396,10 @@ static void test_pppoe(void) {
   printf("HEALTH_DASHBOARD\t\"%s\": %s,\n", x, s_error ? "false" : "true")
 
 int main(void) {
+  s_error = false;
+  test_fcs();
+  DASHBOARD("fcs");
+
   s_error = false;
   test_lcp();
   DASHBOARD("lcp");

test/unit_test.c

@@ -3039,6 +3039,13 @@ static void test_crc32(void) {
   ASSERT(mg_crc32(mg_crc32(0, "ab", 2), "c", 1) == 891568578);
 }
 
+static void test_crc16(void) {
+  ASSERT(mg_crc16(0, 0, 0) == 0);
+  ASSERT(mg_crc16(0, "a", 1) == 0x82f7);
+  ASSERT(mg_crc16(0, "abc", 3) == 0x9e25);
+  ASSERT(mg_crc16(mg_crc16(0, "ab", 2), "c", 1) == 0x9e25);
+}
+
 static void us(struct mg_connection *c, int ev, void *ev_data) {
   struct mg_http_message *hm = (struct mg_http_message *) ev_data;
   if (ev == MG_EV_HTTP_MSG && mg_match(hm->uri, mg_str("/upload"), NULL)) {
@@ -5512,6 +5519,7 @@ int main(void) {
   test_str();
   test_match();
   test_crc32();
+  test_crc16();
   DASHBOARD("misc");
 
   s_error = false;