wt/cpp-httplib
1
0
Fork 0
mirror of https://github.com/yhirose/cpp-httplib.git synced 2026-10-01 13:12:40 +07:00
Code Issues Packages Projects Releases Wiki Activity

Fix compilation on BoringSSL by replacing ASN1_TIME_to_tm (#2354)

Browse Source 
* Fix compilation on BoringSSL by replacing ASN1_TIME_to_tm

BoringSSL doesn't expose `ASN1_TIME_to_tm`.
This patch switches to using `ASN1_TIME_diff` to calculate `time_t`.
This is supported by OpenSSL, LibreSSL, and BoringSSL, and also avoids
the platform-specific `timegm` vs `_mkgmtime` logic.

Signed-off-by: Adrien Gallouët <adrien@gallouet.fr>

* Format code

Signed-off-by: Adrien Gallouët <adrien@gallouet.fr>

* Use detail::scope_exit

Signed-off-by: Adrien Gallouët <adrien@gallouet.fr>

---------

Signed-off-by: Adrien Gallouët <adrien@gallouet.fr>
This commit is contained in:
Adrien Gallouët
2026-02-11 07:55:07 -10:00
committed by GitHub
parent 77d945d3b6
commit 4e75a84b39
1 changed files with 13 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
httplib.h
+13 -11
View File
@@ -15461,18 +15461,20 @@ inline bool get_cert_validity(cert_t cert, time_t &not_before,
auto na = X509_get0_notAfter(x509);
if (!nb || !na) return false;
// Convert ASN1_TIME to time_t
struct tm tm_nb = {}, tm_na = {};
if (ASN1_TIME_to_tm(nb, &tm_nb) != 1) return false;
if (ASN1_TIME_to_tm(na, &tm_na) != 1) return false;
ASN1_TIME *epoch = ASN1_TIME_new();
if (!epoch) return false;
auto se = detail::scope_exit([&] { ASN1_TIME_free(epoch); });
if (!ASN1_TIME_set(epoch, 0)) return false;
int pday, psec;
if (!ASN1_TIME_diff(&pday, &psec, epoch, nb)) return false;
not_before = 86400 * (time_t)pday + psec;
if (!ASN1_TIME_diff(&pday, &psec, epoch, na)) return false;
not_after = 86400 * (time_t)pday + psec;
#ifdef _WIN32
not_before = _mkgmtime(&tm_nb);
not_after = _mkgmtime(&tm_na);
#else
not_before = timegm(&tm_nb);
not_after = timegm(&tm_na);
#endif
return true;
}