mirror of
http://thekelleys.org.uk/git/dnsmasq.git
synced 2026-10-25 12:14:38 +00:00
Simon Kelley
36d081e374
The addition of "(not supported)" to logs of DS and DNSKEY replies overflows the buffer used to construct the string. Re-arrange things to avoid this, and add checks to avoid the same problem if the logging calls change in the future. Thanks to Yiwei Hou for finding this. The problem exists is DNSSEC is enabled and query logging is also enabled. The overwrite is of bounded length and the bytes written are not in control of an attacker, so this is not considered a likely remote-execution vector.