dnsmasq

wt/dnsmasq

0 Fork 0

mirror of http://thekelleys.org.uk/git/dnsmasq.git synced 2026-10-29 12:50:47 +00:00

T

DL6ER 4388c38468 Fix bogus 256-byte DHCPv6 vendor-class option.

lookup_dhcp_len() returns the flag word from the option table, so
since 1af6ee6468 an option carrying
OT_DHCP6_VENDOR yields an opt_len of 0x0100.

--dhcp-option=option6:vendor-class,343 has a purely decimal argument
list and therefore takes the is_dec branch, which comes long before
the new OT_DHCP6_VENDOR branch, and

  if (opt_len != 0)
    new->len = opt_len;

sets new->len to 256. The value is then written by shifting an int by
up to 2040 bits, which is undefined behavior, and a 256-byte
vendor-class option ends up on the wire:

  $ dnsmasq --test --dhcp-option=option6:vendor-class,343
  option.c:1715:23: runtime error: shift exponent 2040 is too large
  for 32-bit type 'int'
  dnsmasq: syntax check OK.

The numeric spelling option6:16,343 takes the same path. Before
1af6ee6 both were rejected, as vendor-class was OT_INTERNAL back then.

Keep the is_dec branch away from OT_DHCP6_VENDOR, so the dedicated
parser runs and reports the missing vendor class instead.

Signed-off-by: DL6ER <dl6er@dl6er.de>

2026-08-16 21:10:45 +01:00

bld

Remove hash-questions.c - no longer required.

2024-11-02 21:29:47 +00:00

contrib

Fix OOB writes in contrib/leasequesry/leasequery.c

2026-05-30 15:58:52 +01:00

dbus

Allow configuring filter-A/AAAA via dbus.

2023-03-08 15:35:05 +00:00

logo

tweak favicon