wt/finit
1
0
Fork 0
mirror of https://github.com/troglobit/finit.git synced 2026-10-01 13:33:09 +07:00
Code Issues Packages Projects Releases Wiki Activity

fnwrite(): call fclose() separately, found by Coverity Scan

Browse Source 
If any of the fputs() calls fails we will not call fclose() and thus
cause resource loss.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This commit is contained in:
Joachim Wiberg
2021-04-07 14:32:12 +02:00
parent 34875f57a5
commit 12eaa3073a
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/util.c
+3 -3
View File
@@ -105,9 +105,9 @@ int fnwrite(char *value, char *fmt, ...)
return -1;
/* echo(1) always adds a newline */
if (fputs(value, fp) == EOF ||
fputs("\n", fp) == EOF ||
fclose(fp) == EOF)
if (fputs(value, fp) == EOF || fputs("\n", fp) == EOF)
rc = -1;
if (fclose(fp) == EOF)
rc = -1;
else
rc = 0;