wt/finit
1
0
Fork 0
mirror of https://github.com/troglobit/finit.git synced 2026-10-02 05:52:48 +07:00
Code Issues Packages Projects Releases Wiki Activity

logit: fix parse_prio(), check result of parse

Browse Source 
clang-tidy complained that parse_prio() always returned OK(0), turns out
it was right.  This patch adds validation of the parsing.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This commit is contained in:
Joachim Wiberg
2025-07-02 16:43:43 +02:00
parent 10a1257e47
commit d95fc5f790
1 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/logit.c
+17 -4
View File
@@ -103,10 +103,12 @@ static int logit(int level, char *buf, size_t len)
return 0;
}
static int parse_prio(char *arg, int *f, int *l)
static int parse_prio(char *arg, int *fac, int *lvl)
{
char *duparg = strdup(arg);
char *ptr, *prio;
const char *prio;
char *ptr;
int found;
if (!duparg)
prio = arg;
@@ -117,23 +119,34 @@ static int parse_prio(char *arg, int *f, int *l)
if (ptr) {
*ptr++ = 0;
found = -1;
for (int i = 0; facilitynames[i].c_name; i++) {
if (!strcmp(facilitynames[i].c_name, prio)) {
*f = facilitynames[i].c_val;
found = facilitynames[i].c_val;
break;
}
}
if (found == -1)
return 1;
*fac = found;
prio = ptr;
}
found = -1;
for (int i = 0; prioritynames[i].c_name; i++) {
if (!strcmp(prioritynames[i].c_name, prio)) {
*l = prioritynames[i].c_val;
found = prioritynames[i].c_val;
break;
}
}
if (found == -1)
return 1;
*lvl = found;
if (duparg != arg)
free(duparg);