wt/finit
1
0 Fork 0
mirror of https://github.com/troglobit/finit.git synced 2026-11-06 15:51:03 +00:00
Code Issues Packages Projects Releases Wiki Activity
420 Commits 12 Branches 77 Tags
dd7f0ce090f8abeb95d6f7bda6df644e97ccbefc
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Joachim Nilsson dd7f0ce090 Fix Coverity CID 87571: Uninitialized scalar variable (UNINIT) 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-02-18 22:18:02 +01:00
Joachim Nilsson 8c955836dd Load plugins before finit.conf is parsed, needed by internal inetd services 
This patch is slightly sub-optimal, since it will causes us to load all
availble plugins, not just those referenced by finit.conf.  However, in
the short term perspective we need to reference internal inted services
provided by plugins from finit.conf, so the dependency order is clear.

In the midterm perspective we want to add support for SIGHUP to reload
finit.conf, but not plugins.  So again, this is an OK patch.

One fix would be to allow loading of all plugins, parse finit.conf and
then unload all unused plugins before continuing.

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-02-18 22:04:36 +01:00
Joachim Nilsson 183022ebe4 Initial support for RFC 868 (rdate), internal inetd service. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-02-18 22:04:31 +01:00
Joachim Nilsson 33be077f92 TODO: Remember to support non-getty logins. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-02-18 16:53:00 +01:00
Joachim Nilsson 6a137fa73c TODO: Update with info on internal inetd services, like time, echo etc. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-02-18 15:17:00 +01:00
Joachim Nilsson 25c85dfc88 Add markdown hinting for Emacs. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-02-16 10:27:16 +01:00
Joachim Nilsson 58cc96115c Initial support for figuring out inbound interface for inetd connections 
This patch adds initial support (only SOCK_STREAM verified!) for
figuring out the inbound interface for inetd service connections.

The intention is to use this later on for a very simple tcpwrappers
replacement, e.g: `deny telnet eth0 eth3`

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-02-16 10:26:54 +01:00
Joachim Nilsson b4b63d3722 Trap segfaults caused by service callbacks in separate process context 
This patch traps segfaults caused by 3rd party service callbacks in a
separate process context.  Effectively preventing a single programming
mistake from taking down the entire system.  Previously it was up to the
callback coder to write error free code so that PID 1 did not crash.

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-02-16 10:21:03 +01:00
Joachim Nilsson d6efe85a57 Silence launch of inetd services. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-02-09 00:57:21 +01:00
Joachim Nilsson 51b27e8372 Revert "Use vfork() instead of fork() before exec()" 
This reverts commit 074686b520.  Which
turned out to not work so well after all.  For instance, launching TTYs
in a background process completely blocked inetd services from even
starting up listening sockets ... proper fork seems to work fine though.

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-02-09 00:45:09 +01:00
Joachim Nilsson cac612c485 Remember to fix these ... 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-02-09 00:43:33 +01:00
Joachim Nilsson a5b9f566b3 Initial support for inetd/on-demand services \o/ 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-02-09 00:43:15 +01:00
Joachim Nilsson 0d098616e8 Whitespace changes only 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-02-01 17:28:36 +01:00
Joachim Nilsson 63722a20ac Allow mixed case configuration commands in finit.conf 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-02-01 17:27:18 +01:00
Joachim Nilsson 6f6ab6bc33 Minor whitespace fixes 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-29 12:34:30 +01:00
Joachim Nilsson 7f0a85c106 Updated inetd syntax and add possible bug, needs investigating. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-29 12:33:35 +01:00
Joachim Nilsson 46ddf4bcc6 Commence new -dev phase. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-24 23:56:52 +01:00
Joachim Nilsson f5ab075f9d Upgrade libuEv to v1.0.4 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-24 23:54:53 +01:00
Joachim Nilsson 9b361864fa Fix make dist target for v1.11 release. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-24 16:16:13 +01:00
Joachim Nilsson 41b0dc41a6 Update ChangeLog for v1.11 release. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-24 16:13:46 +01:00
Joachim Nilsson cab339c857 Simplify build example. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-24 16:07:55 +01:00
Joachim Nilsson dcb42602c9 Cleanup README for release. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-24 16:04:54 +01:00
Joachim Nilsson 9e446557b4 Change Coverity Scan branch to use 'dev' instead of master. 
We don't want to run out of scan tokens for every README update.  This
also means the introduction of a new workflow.  All new development must
be staged to the dev branch before being merged to master.

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-24 15:29:16 +01:00
Joachim Nilsson a3d76c58a4 Expand on how plugins can interact with system bootstrap. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-21 19:34:01 +01:00
Joachim Nilsson e0e0581d10 Trim slogan ... 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-21 13:29:35 +01:00
Joachim Nilsson ef75d5ec31 Cleanup Introduction and add Bootstrap section. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-21 13:25:24 +01:00
Joachim Nilsson dfeabd8bae Improve inetd syntax proposal 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-21 13:15:16 +01:00
Joachim Nilsson 7aa687bad9 Reindent to more 'pure' Markdown and remove fixed event lib TODO. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-19 21:24:06 +01:00
Joachim Nilsson c2ea2c1193 Reindent to more 'pure' Markdown. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-19 21:12:14 +01:00
Joachim Nilsson 291b22e987 Give up and add actual link to GIT commit. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-18 23:46:21 +01:00
Joachim Nilsson a091b69dd6 Another try ... 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-18 23:45:16 +01:00
Joachim Nilsson 887c84a0d1 Attempt to fix GIT commit auto linking. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-18 23:44:27 +01:00
Joachim Nilsson 5009d54ab8 Reindent to more 'pure' Markdown. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-18 23:43:04 +01:00
Joachim Nilsson 840ade6da7 Bump version for next release, fix make dist and rename NEWS --> CHANGELOG 
- Bump version for coming 1.11 release
- Update `make dist` to use Kentzo's `git-archive-all` from
  https://github.com/Kentzo/git-archive-all
- Rename NEWS --> CHANGELOG and update for coming release
- Update CHANGELOG with info on the libuEv migration

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-18 23:22:39 +01:00
Joachim Nilsson 030aa70842 Simplify. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-18 22:29:34 +01:00
Joachim Nilsson dea3ae857b Steal controlling TTY on fallback console to enable job control. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-18 22:25:04 +01:00
Joachim Nilsson 9f5172b0d1 Try removing delayed start of TTYs, should not be needed anymore. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-18 21:40:09 +01:00
Joachim Nilsson e0529a5597 Unblock all signals blocked by finit when starting children 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-18 21:40:05 +01:00
Joachim Nilsson 425cd17e57 Initial conversion to use libuEv for all event handling. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-18 00:53:14 +01:00
Joachim Nilsson 0669a9cb81 Fix missing #include for copyfile() 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-18 00:46:06 +01:00
Joachim Nilsson 5e040449c4 Add libuEv as submodule for event handling. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-07 02:59:21 +01:00
Joachim Nilsson 074686b520 Use vfork() instead of fork() before exec() 
If running on older Linux systems, or any BSD UNIX, vfork()
is more efficient when we are about to call exec() anyway.

For more info on vfork() vs fork(), see Stack Exchange:
http://stackoverflow.com/questions/4259629/what-is-the-difference-between-fork-and-vfork

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-06 23:38:47 +01:00
Joachim Nilsson d40f52357e Restructure and add section on Watchdog process supervision 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-06 21:45:14 +01:00
Joachim Nilsson 076f77a31b Update TODO: more on inetd and at support. 
Also a minor fix to the README.

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-06 20:54:52 +01:00
Joachim Nilsson 8f1c16a8a5 Update TODO with section on Cron. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-01 02:04:50 +01:00
Joachim Nilsson b149dbc73e Update TODO 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2015-01-01 00:11:44 +01:00
Joachim Nilsson aa8d6a7294 Bump version for 1.10 release. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-27 22:33:24 +01:00
Joachim Nilsson a94dde403f Update NEWS to Markdown syntax and add info on next release. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-27 09:42:49 +01:00
Joachim Nilsson 9bb7e7b014 Change NEWS documentation from reST to Markdown 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-27 09:19:33 +01:00
Joachim Nilsson 02a97e8d7d Fix various problems with unchecked return values from syscalls. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-27 00:12:07 +01:00
Joachim Nilsson def759fe41 run_interactive(): Fix a potential file descriptor leak. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 23:45:20 +01:00
Joachim Nilsson 939cfc2476 pidfile_read(): Reindent. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 23:44:00 +01:00
Joachim Nilsson 7f2c73468f libite/rsync.c: Fix build regression from previous commit. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 23:37:04 +01:00
Joachim Nilsson 81a368f710 Fix problem with unchecked return value of mkdir(), wrap in makedir() macro. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 23:27:15 +01:00
Joachim Nilsson 4e975e4974 plugin.c:load_one() - Comment on resource leak, we never unload plugins atm. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 23:24:49 +01:00
Joachim Nilsson a296c2dd00 pidfile_read(): Fix potential integer overflow when reading PID 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 23:02:54 +01:00
Joachim Nilsson 5ff7994852 touch(): Check return value of mknod(), report error if errno != EEXIST. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 22:57:23 +01:00
Joachim Nilsson 1bdcef9a2c run_interactive(): Fix file descriptor leak when debug is enabled. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 22:49:31 +01:00
Joachim Nilsson f621117eb9 README: Update section on plugins with info on hooks and I/O plugins. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 18:48:25 +01:00
Joachim Nilsson 83cec7129a run_interactive(): Fix copy-paste bug introduced in 06b33c5. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 17:58:50 +01:00
Joachim Nilsson 06b33c58fd run_interactive(): Fix descriptor leak. 
Make sure to close dup()'ed descriptors when we're done with them.
Thanks to Coverity Scan for finding this nasty one!

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 17:30:58 +01:00
Joachim Nilsson 8ce39f592c procname_kill(): Fix possible resource leak and let's use opendir() errno 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 17:22:55 +01:00
Joachim Nilsson d37c451e81 svc_start(): Fix out of bounds write to args[] array. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 17:20:27 +01:00
Joachim Nilsson a7ff1a61d5 svc_start(): Fix swapped arguments to dup2() and add close(fd), descriptor leak. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 17:17:47 +01:00
Joachim Nilsson 8349909f60 helpers.c:run_interactive() - Check arguments and return values better. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 17:08:00 +01:00
Joachim Nilsson 3a2cf30f47 README: Minor touch up. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 16:41:04 +01:00
Joachim Nilsson 9a3cab3645 TODO: Remove finished items now documented in README 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 16:40:43 +01:00
Joachim Nilsson 7dbc02f879 Standardize on two-space indented * for bullet lists in Markdown 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 16:13:53 +01:00
Joachim Nilsson a39f75744c Update TODO to Markdown syntax. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 16:08:59 +01:00
Joachim Nilsson 5742c6591a Change TODO documentation from reST to Markdown 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 15:59:34 +01:00
Joachim Nilsson 588901ee4c Update README to Markdown syntax. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 15:56:50 +01:00
Joachim Nilsson e30d2aae19 Change documentation from reST to Markdown 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-26 15:55:33 +01:00
Joachim Nilsson 463e4f12f8 Update Coverity URL and add section on hooks, plugins & callbacks. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-24 18:21:47 +01:00
Joachim Nilsson 01c2817005 Add support for Coverity Scan 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-24 13:49:18 +01:00
Joachim Nilsson 1a16aab970 queue.h: Upgrade to a newer slightly bugfiex version of OpenBSD queue.h 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-11-03 20:56:11 +01:00
Joachim Nilsson 8247344f0d helpers.c:set_hostname() - Fix resource and memory leaks. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-10-31 15:26:49 +01:00
Joachim Nilsson 2fdd64a2d8 helpers.c:run() - Fix resource and memory leaks. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-10-31 15:16:00 +01:00
Joachim Nilsson 22ed4e7f73 svc.c - Break out nested function. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-10-31 14:58:13 +01:00
Joachim Nilsson 327ac9f931 libite:rsync.c - Break out nested function. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-10-31 14:56:51 +01:00
Joachim Nilsson 5ad0c38fe8 Sanity check plugpath as well, no point in searching for plugins otherwise. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-10-30 22:11:23 +01:00
Joachim Nilsson 757911f149 Bump version for release and update copyright years. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-21 16:03:54 +02:00
Joachim Nilsson 35b771fb42 Add empty space for formatting. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-21 15:51:33 +02:00
Joachim Nilsson 720f1b0e5b Strip output when loading .conf files. 
If not standard finit.conf, then we want to show just the base name.
E.g., loading first /etc/finit.conf then /etc/finit.d/services.conf

Loading configuration ............. vs
Loading services configuration ....

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-21 15:46:09 +02:00
Joachim Nilsson 292a3be515 lite.h: Add some helper string comparison methods. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-21 15:45:23 +02:00
Joachim Nilsson 5ed407e493 helpers.c: Fix mix of off-by-one errors in new print() code. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-21 14:09:23 +02:00
Joachim Nilsson 40988b901c Unify print_desc() & print_result() in print() and refactor ... 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-21 14:05:56 +02:00
Joachim Nilsson 26d49b2027 Yet another minor bugfix to new include function. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-21 12:05:55 +02:00
Joachim Nilsson 10386ee4de Bug fix and document new include <CONF> syntax. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-21 12:03:10 +02:00
Joachim Nilsson 773d2e65d6 README: Update docs on extended syntax and behavior for tty setting 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-21 11:17:31 +02:00
Joachim Nilsson 3e29d883fa tty.c:tty_start() - Fix strcmp() foobar from f6f2895, must use strncmp() 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-21 11:08:34 +02:00
Joachim Nilsson f6f2895524 Add support for a fallback shell if no tty is setup 
Try to do better by the user, by default, if no tty is specified in the
finit.conf.  This way the user will at least have a way to interact with
the system and repair it.

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-19 22:58:20 +02:00
Joachim Nilsson 62287f8fcc Add support for including .conf files. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-19 22:56:19 +02:00
Joachim Nilsson be3257f805 print_desc() - Allow arguments to be NULL. 
Signed-off-by: Joachim Nilsson <joachim.nilsson@westermo.se>
 2014-04-19 22:25:56 +02:00
Joachim Nilsson 1bf3aa528a Fix duplicate link and cleanup contact section. 
Signed-off-by: Joachim Nilsson <joachim.nilsson@westermo.se>
 2014-04-19 19:31:00 +02:00
Joachim Nilsson 056236c9f8 Freshen up README, TODO, and .conf example, spell check. 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-19 19:19:57 +02:00
Joachim Nilsson 71fff76111 svc.[ch]: Fix possible out of bounds and NULL ptr deref 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-12 16:41:20 +02:00
Joachim Nilsson 1095724e5c libite: Fix cppcheck warnings in rsync unit test 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-12 16:34:57 +02:00
Joachim Nilsson e81c2f2f90 libite: Minor style cleanup of fsendfile() 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-12 16:21:41 +02:00
Joachim Nilsson 9f91b4c050 libite: Simplify and fix another memleak in copyfile() 
- Simplify: reduce indentation depth
- Always check for error condition first, cleaner code
- Make sure buffer is always freed, use same exit everyhere
- Use readable, but still short, local variable names

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-12 16:11:59 +02:00
Joachim Nilsson 7ada824e3e Makefile: Add support for make check to run cppcheck 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
 2014-04-12 16:08:30 +02:00