Fix make dist target for v1.11 release.

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "libuev"]
+	path = libuev
+	url = https://github.com/troglobit/libuev.git

.travis.yml

@@ -1,6 +1,21 @@
-# Travis CI integration
+# Travis CI integration -- https://travis-ci.org/troglobit/finit
 language: c
 compiler:
   - gcc
 
+env:
+  global:
+   # The next declaration is the encrypted COVERITY_SCAN_TOKEN, created
+   #   via the "travis encrypt" command using the project repo's public key
+   - secure: "eOiuHs02lG2Uv146K9dMqucGTWUJFEhpz1oAtwe+kPrRXsXWc20hYMO+DSpMgD05vSvNeQA6p7h7LdRFQ+/g/Obj27TsOE+RKkUvRAtdwzxnKVyii9C/nmML8cFw7rIA0VS8O9mAkVYeyDxNDupBp3e9DPCibhKPvqCvioTnyy4="
+
+addons:
+  coverity_scan:
+    project:
+      name: "troglobit/finit"
+      description: "finit | Fast & Extensible init for Linux"
+    notification_email: troglobit@gmail.com
+    build_command:      "make"
+    branch_pattern:     dev
+
 script: make

CHANGELOG

@@ -0,0 +1 @@
+CHANGELOG.md

CHANGELOG.md

@@ -0,0 +1,278 @@
+Change Log
+==========
+
+All notable changes to the project are documented in this file.
+
+
+[1.11] - 2015-01-24
+-------------------
+
+The [libuEv] release.
+
+### Changes
+* Now using the asynchronous libuEv library for handling all events:
+  signals, timers and listening to sockets or file descriptors.
+* Rename NEWS.md --> CHANGELOG.md, with symlinks for `make install`
+* Attempt to align with http://keepachangelog.com/ for this file.
+* Travis CI now only invokes Coverity Scan from the 'dev' branch.  This
+  means that all development, except documentation updates, must go into
+  that branch.
+
+### Fixes
+* Fix bug with finit dying when no `tty` is defined in `finit.conf`, now
+  even the fallback shell has control over its TTY, see fix in GIT
+  commit [dea3ae8] for this.
+
+
+[1.10] - 2014-11-27
+-------------------
+Major bug fix release.
+
+### Changes
+* Project now relies on static code analysis from Coverity, so this
+  release contains many serious bug fixes.
+* Convert to use Markdown for README, NEWS and TODO.
+* Serious update to README and slight pruning of finished TODO items.
+
+### Fixes
+* Fix serious file descriptor and memory leaks in the following
+  functions.  In particular the leaks in `run_interactive()` are very
+  serious since that function is called every time a service is started
+  and/or restarted!  For details, see the GIT log:
+  * `helpers.c:run()`
+  * `helpers.c:run_interactive()`
+  * `helpers.c:set_hostname()`
+  * `helpers.c:procname_kill()`
+* `svc.c:svc_start()`: Fix swapped arguments to dup2() and add close(fd)
+  to prevent descriptor leak.
+* `svc.c:svc_start()`: Fix out of bounds write to local stack variable,
+  wrote off-by-one outside array.
+* Several added checks for return values to `mknod()`, `mkdir()`,
+  `remove()`, etc.
+
+
+[1.9] - 2014-04-21
+------------------
+
+### Changes
+* Add support for an include directive to `.conf` files
+* Fallback to `/bin/sh` if user forgets tty setting
+* Initial support for restarting lost services during `norespwan`
+
+### Fixes
+* Bug fixes, code cleanup
+* Handle `SIGHUP` from service callback properly when switching runlevel
+* Misc. major (memleak) and minor fixes and additions to `libite/lite.h`
+
+
+[1.8] - 2013-06-07
+------------------
+
+### Changes
+* Support for runlevels, with a bootstrap runlevel 'S'
+* Support for saving previous and current runlevel to UTMP
+* Support for new `finit.conf` commands: run, task, and runlevel
+* Support for tty and console commands in `finit.conf`, like services
+  but for launching multiple getty logins
+* New tty plugin to monitor TTYs coming and going, like USB TTYs
+
+### Fixes
+* Bugfixes to libite
+
+
+[1.7] - 2012-10-08
+------------------
+
+### Changes
+* Show `__FILE__` in `_d()` debug messages, useful for plugins with
+  similarily named callbacks. Also, only in debug mode anyway
+* Make sure to cleanup recorded PID when a service is lost.  Required by
+  service plugins for their callbacks to work.
+* Only clear screen when in verbose mode. Maybe this should be removed
+  altogether?
+
+### Fixes
+* Bugfix: Do not `free()` static string in `finit.conf` parser
+
+
+[1.6] - 2012-10-06
+------------------
+
+### Changes
+* Skip `.` and `..` in plugin loader and display error when failing to
+  load plugins
+* Support for overriding `/etc/finit.d` with `runparts DIR` in
+  `finit.conf`
+* Revoke support for starting services not starting with a slash.
+* Prevent endless restart of non-existing services in `finit.conf`
+* Support for sysvinit style startstop scripts in `/etc/finit.d`
+
+### Fixes
+* Minor fix to alsa-utils plugin to silence on non-existing cards
+
+
+[1.5] - 2012-10-03
+------------------
+
+### Changes
+* Use bootmisc plugin to setup standard FHS 2.3 structure in `/var`
+* Added `FLOG_WARN()` syslog macro, for plugins
+* Add plugin dependency resolver. Checks `plugin_t` for `.depends`
+
+
+[1.4] - 2012-10-02
+------------------
+
+### Changes
+* Start refactoring helpers.c into a libite.so (-lite).  This means
+  other user space applications/daemons can make use of the neat toolbox
+  available in finit
+* Use short-form -s/-w -u to work with BusyBox hwclock as well
+* Use RTLD_GLOBAL flag to tell dynamic loader to load dependent .so
+  files as well.  Lets other plugins use global symbols.
+* Greatly simplify svc hook for external plugins and cleanup plugin API.
+* And more ... see the GIT log for more details.
+
+### Fixes
+* Fix I/O plugin watcher and load plugins earlier for a new hook
+
+
+[1.3] - 2012-09-28
+------------------
+
+### Changes
+* Cleanup public plugin API a bit and add new pid/pidfile funcs
+* Add plugin hook to end of service startup
+* Remove finit.h from svc.h, plugins should not need this.
+* Move utility macros etc. to helpers.h
+* Make `finit.h` daemon internal, only
+* Move defines of FIFO, conf and rcS.d to Makefile => correct paths
+* Add support for installing required headers in system include dir
+* Better support for distributions and packagers with install-exec,
+  install-data, and install-dev targets in Makefile.  Useful if you want
+  to call targets with different `$DESTDIR`!
+* Makefile fixes for installation, paths encoded wrong
+* Strip binaries + .so files, support for `$(CROSS)` toolchain strip
+* Default install is now to `/sbin/finit` and `/usr/`
+* Note change in `$PLUGIN_DIR` environemnt variable to `$plugindir`
+
+
+[1.2] - 2012-09-27
+------------------
+
+### Changes
+* Update README with section on building and enviroment variables
+
+### Fixes
+* Fix installation paths encoded in finit binary
+
+
+[1.1] - 2012-09-27
+------------------
+
+### Changes
+* Rename signal.[ch]-->sig.[ch] to avoid name clash w/ system headers
+
+### Fixes
+* Build fixes for ARM eabi/uClibc
+
+
+[1.0] - 2012-09-26
+------------------
+
+### Changes
+* New plugin based system for all odd extensions
+* New service monitor that restarts services if they die
+* New maintainer at GitHub http://github.com/troglobit/finit
+* Add standard LICENSE and AUTHORS files
+* New focus: embedded systems and small headless servers
+
+
+[0.6] - 2010-06-14
+------------------
+
+* Don't start consolekit manually, dbus starts it (rtp)
+* Unmount all filesystems before rebooting
+* Disable `USE_VAR_RUN_RESOLVCONF` for Mandriva
+* Unset terminal type in Mandriva before running X
+* Remove extra sleep in finit-alt before calling services.sh (caio)
+
+
+[0.5] - 2008-08-21
+------------------
+
+* Add option to start dbus and consolekit before the X server
+* finit-alt listens to `/dev/initctl` to work with `reboot(8)` (smurfy)
+* Write runlevel to utmp, needed by Printerdrake (Pascal Terjan)
+* Fix ownership of `/var/run/utmp` (reported by Pascal Terjan)
+* Remove obsolete code to load AGP drivers
+* Conditional build of `/etc/resolveconf/run` support
+* Add support to `/var/run/resolvconf` in Mandriva (blino)
+
+
+[0.4] - 2008-05-16
+------------------
+
+* Default username for finit-alt configurable in Makefile
+* Create loopback device node in finit-alt (for squashfs)
+* Add option to use built-in run-parts instead of `/bin/run-parts`
+* Ignore signal instead of setting to an empty handler (Metalshark)
+* Handle pam_console permissions in finit-alt for Mandriva
+* Add services.sh example and nash-hotplug patch for Mandriva
+* Mount `/proc/bus/usb` in Mandriva
+* Add runtime debug to finit-alt if finit_debug parameter is specified
+* Read configuration from `/etc/finit.conf`
+* Run getty with openvt on the virtual terminal
+
+
+[0.3] - 2008-02-23
+------------------
+
+* Change poweroff method to `reboot(RB_POWER_OFF)` (Metalshark)
+* Remove duplicate `unionctl()` reimplementation error
+* Fix string termination in path creation
+* Mount `/var/lock` and `/var/run` as tmpfs
+
+
+[0.2] - 2008-02-19
+------------------
+
+* Replace `system("touch")` with `touch()` in finit-mod (Metalshark)
+* Disable `NO_HCTOSYS` by default to match stock Eeepc kernel
+* Drop `system("rm -f")` to clean `/tmp`, its a fresh mounted tmpfs
+* Write ACPI sleep state to `/sys/power/state` instead of
+  `/proc/acpi/sleep` (Metalshark)
+* Use direct calls to set loopback instead of `system("ifconfig")`
+* Replace `system("cat")` and `system("dd")` with C implementation
+* Moved finit-mod and finit-alt helpers to `helpers.c`
+* Replace `system("echo;cat")` to draw shutdown splash with C calls
+
+
+0.1 - 2008-02-14
+----------------
+
+* Initial release
+
+[libuEv]: https://github.com/troglobit/libuev
+[dea3ae8]: https://github.com/troglobit/finit/commit/dea3ae8
+[1.11]: https://github.com/troglobit/finit/compare/1.10...HEAD
+[1.10]: https://github.com/troglobit/finit/compare/1.9...1.10
+[1.9]: https://github.com/troglobit/finit/compare/1.8...1.9
+[1.8]: https://github.com/troglobit/finit/compare/1.7...1.8
+[1.7]: https://github.com/troglobit/finit/compare/1.6...1.7
+[1.6]: https://github.com/troglobit/finit/compare/1.5...1.6
+[1.5]: https://github.com/troglobit/finit/compare/1.4...1.5
+[1.4]: https://github.com/troglobit/finit/compare/1.3...1.4
+[1.3]: https://github.com/troglobit/finit/compare/1.2...1.3
+[1.2]: https://github.com/troglobit/finit/compare/1.1...1.2
+[1.1]: https://github.com/troglobit/finit/compare/1.0...1.1
+[1.0]: https://github.com/troglobit/finit/compare/0.9...1.0
+[0.9]: https://github.com/troglobit/finit/compare/0.8...0.9
+[0.8]: https://github.com/troglobit/finit/compare/0.7...0.8
+[0.7]: https://github.com/troglobit/finit/compare/0.6...0.7
+[0.6]: https://github.com/troglobit/finit/compare/0.5...0.6
+[0.5]: https://github.com/troglobit/finit/compare/0.4...0.5
+[0.4]: https://github.com/troglobit/finit/compare/0.3...0.4
+[0.3]: https://github.com/troglobit/finit/compare/0.2...0.3
+[0.2]: https://github.com/troglobit/finit/compare/0.1...0.2
+

Makefile

@@ -26,14 +26,16 @@
 	uninstall-exec uninstall-data uninstall-dev
 
 #VERSION    ?= $(shell git tag -l | tail -1)
-VERSION    ?= 1.9
+VERSION    ?= 1.11
 NAME        = finit
 PKG         = $(NAME)-$(VERSION)
 DEV         = $(NAME)-dev
-ARCHIVE     = $(PKG).tar.xz
+ARCHTOOL    = `which git-archive-all`
+ARCHIVE     = $(PKG).tar
+ARCHIVEZ    = ../$(ARCHIVE).xz
 EXEC        = finit reboot
 HEADERS     = plugin.h svc.h helpers.h queue.h
-DISTFILES   = LICENSE README NEWS finit.conf services
+DISTFILES   = LICENSE README CHANGELOG finit.conf services
 OBJS        = finit.o conf.o helpers.o sig.o svc.o plugin.o tty.o
 SRCS        = $(OBJS:.o=.c)
 DEPS        = $(addprefix .,$(SRCS:.c=.d))
@@ -57,22 +59,24 @@ FINIT_RCSD ?= $(sysconfdir)/finit.d
 CFLAGS     += -W -Wall -Werror -Os
 # Disable annoying gcc warning for "warn_unused_result", see GIT 37af997
 CPPFLAGS   += -U_FORTIFY_SOURCE
-CPPFLAGS   += -Ilibite -D_XOPEN_SOURCE=600 -D_BSD_SOURCE -D_GNU_SOURCE
+CPPFLAGS   += -Ilibite -Ilibuev
+CPPFLAGS   += -D_XOPEN_SOURCE=600 -D_BSD_SOURCE -D_GNU_SOURCE
 CPPFLAGS   += -DVERSION=\"$(VERSION)\" -DWHOAMI=\"`whoami`@`hostname`\"
 CPPFLAGS   += -DFINIT_FIFO=\"$(FINIT_FIFO)\" -DFINIT_CONF=\"$(FINIT_CONF)\"
 CPPFLAGS   += -DFINIT_RCSD=\"$(FINIT_RCSD)\" -DPLUGIN_PATH=\"$(plugindir)\"
 LDFLAGS    += -rdynamic -L$(TOPDIR)/libite
-DEPLIBS     = libite/libite.so
+DEPLIBS     = libite/libite.so libuev/libuev.a
 LDLIBS     += -ldl -lite
 
 include common.mk
 export libdir plugindir incdir ROOTDIR CPPFLAGS LDFLAGS LDLIBS
 
 all: $(DEPLIBS) $(EXEC)
-	$(MAKE) -C plugins $@
+	+$(MAKE) -C plugins $@
 
 $(DEPLIBS): Makefile
-	$(MAKE) -C libite all
+	+$(MAKE) -C libite all
+	+$(MAKE) -C libuev all
 
 $(OBJS): Makefile
 
@@ -133,21 +137,32 @@ uninstall: uninstall-exec uninstall-data uninstall-dev
 
 clean:
 	-@$(RM) $(OBJS) $(DEPS) $(EXEC)
-	$(MAKE) -C libite  $@
-	$(MAKE) -C plugins $@
+	+$(MAKE) -C plugins $@
+	+$(MAKE) -C libite  $@
+	+$(MAKE) -C libuev  $@
 
 distclean: clean
 	-@$(RM) $(JUNK) unittest *.o .*.d
-	$(MAKE) -C libite  $@
-	$(MAKE) -C plugins $@
+	+$(MAKE) -C plugins $@
+	+$(MAKE) -C libite  $@
+	+$(MAKE) -C libuev  $@
 
 check:
 	$(CHECK) *.c plugins/*.c libite/*.c
 
 dist:
+	@if [ x"$(ARCHTOOL)" = x"" ]; then \
+		echo "Missing git-archive-all from https://github.com/Kentzo/git-archive-all"; \
+		exit 1; \
+	fi
+	@if [ -e $(ARCHIVEZ) ]; then \
+		echo "Distribution already exists."; \
+		exit 1; \
+	fi
 	@echo "Building xz tarball of $(PKG) in parent dir..."
-	git archive --format=tar --prefix=$(PKG)/ $(VERSION) | xz >../$(ARCHIVE)
-	@(cd ..; md5sum $(ARCHIVE) | tee $(ARCHIVE).md5)
+	@$(ARCHTOOL) ../$(ARCHIVE)
+	@xz ../$(ARCHIVE)
+	@md5sum $(ARCHIVEZ) | tee $(ARCHIVEZ).md5
 
 dev: distclean
 	@echo "Building unstable xz $(DEV) in parent dir..."

NEWS

@@ -1 +0,0 @@
-NEWS.rst

NEWS.rst

@@ -1,169 +0,0 @@
-==============================================================================
-                                    NEWS
-==============================================================================
-
-1.9 (2014-04-21)
-----------------
-* Bug fixes, code cleanup
-* Add support for an include directive to .conf files
-* Fallback to ``/bin/sh`` if user forgets tty setting
-* Handle ``SIGHUP`` from service callback properly when switching runlevel
-* Initial support for restarting lost services during ``norespwan``
-* Misc. major (memleak) and minor fixes and additions to libite/lite.h
-
-
-1.8 (2013-06-07)
-----------------
-* Support for runlevels, with a bootstrap runlevel 'S'
-* Support for saving previous and current runlevel to UTMP
-* Support for new finit.conf commands: run, task, and runlevel
-* Support for tty and console commands in finit.conf, like services but
-  for launching multiple getty logins
-* New tty plugin to monitor TTYs coming and going, like USB TTYs
-* Bugfixes to libite
-
-
-1.7 (2012-10-08)
-----------------
-* Show __FILE__ in _d() debug messages, useful for plugins with
-  similarily named callbacks. Also, only in debug mode anyway
-* Make sure to cleanup recorded PID when a service is lost.  Required by
-  service plugins for their callbacks to work.
-* Bugfix: Do not free() static string in finit.conf parser
-* Only clear screen when in verbose mode. Maybe this should be removed
-  altogether?
-
-
-1.6 (2012-10-06)
-----------------
-* Skip . and .. in plugin loader and display error on failed plugins
-* Support for overriding /etc/finit.d with "runparts DIR" in finit.conf
-* Revoke support for starting services not starting with a slash.
-* Prevent endless restart of non-existing services in finit.conf
-* Support for sysvinit style startstop scripts in /etc/finit.d
-* Minor fix to alsa-utils plugin to silence on non-existing cards
-
-
-1.5 (2012-10-03)
-----------------
-* Use bootmisc plugin to setup standard FHS 2.3 structure in /var
-* Added FLOG_WARN() syslog macro, for plugins
-* Add plugin dependency resolver. Checks plugin_t for .depends
-
-
-1.4 (2012-10-02)
-----------------
-* Fix I/O plugin watcher and load plugins earlier for a new hook
-* Start refactoring helpers.c into a libite.so (-lite).  This means
-  other user space applications/daemons can make use of the neat toolbox
-  available in finit
-* Use short-form -s/-w -u to work with BusyBox hwclock as well
-* Use RTLD_GLOBAL flag to tell dynamic loader to load dependent .so
-  files as well.  Lets other plugins use global symbols.
-* Greatly simplify svc hook for external plugins and cleanup plugin API.
-* And more... see the GIT log for more details.
-
-
-1.3 (2012-09-28)
-----------------
-* Cleanup public plugin API a bit and add new pid/pidfile funcs
-* Add plugin hook to end of service startup
-* Remove finit.h from svc.h, plugins should not need this.
-* Move utility macros etc. to helpers.h
-* Make finit.h daemon internal, only
-* Move defines of FIFO, conf and rcS.d to Makefile => correct paths
-* Add support for installing required headers in system include dir
-* Better support for distributions and packagers with install-exec,
-  install-data, and install-dev targets in Makefile.  Useful if you want
-  to call targets with different $DESTDIR!
-* Makefile fixes for installation, paths encoded wrong
-* Strip binaries + .so files, support for $(CROSS) toolchain strip
-* Default install is now to /sbin/finit and /usr/
-* Note change in $PLUGIN_DIR environemnt variable to $plugindir
-
-
-1.2 (2012-09-27)
-----------------
-* Fix installation paths encoded in finit binary
-* Update README with section on building and enviroment variables
-
-
-1.1 (2012-09-27)
-----------------
-* Build fixes for ARM eabi/uClibc
-* Rename signal.[ch]-->sig.[ch] to avoid name clash w/ system headers
-
-
-1.0 (2012-09-26)
-----------------
-* New plugin based system for all odd extensions
-* New service monitor that restarts services if they die
-* New maintainer at GitHub http://github.com/troglobit/finit
-* Add standard LICENSE and AUTHORS files
-* New focus: embedded systems and small headless servers
-
-
-0.6 (2010-06-14)
-----------------
-* don't start consolekit manually, dbus starts it (rtp)
-* unmount all filesystems before rebooting
-* disable USE_VAR_RUN_RESOLVCONF for Mandriva
-* unset terminal type in Mandriva before running X
-* remove extra sleep in finit-alt before calling services.sh (caio)
-
-
-0.5 (2008-08-21)
-----------------
-* add option to start dbus and consolekit before the X server
-* finit-alt listens to /dev/initctl to work with reboot(8) (smurfy)
-* write runlevel to utmp, needed by Printerdrake (Pascal Terjan)
-* fix ownership of /var/run/utmp (reported by Pascal Terjan)
-* remove obsolete code to load AGP drivers
-* conditional build of /etc/resolveconf/run support
-* add support to /var/run/resolvconf in Mandriva (blino)
-
-
-O.4 (2008-05-16)
-----------------
-* default username for finit-alt configurable in Makefile
-* create loopback device node in finit-alt (for squashfs)
-* add option to use built-in run-parts instead of /bin/run-parts
-* ignore signal instead of setting to an empty handler (Metalshark)
-* handle pam_console permissions in finit-alt for Mandriva
-* add services.sh example and nash-hotplug patch for Mandriva
-* mount /proc/bus/usb in Mandriva
-* add runtime debug to finit-alt if finit_debug parameter is specified
-* read configuration from /etc/finit.conf
-* run getty with openvt on the virtual terminal
-
-
-0.3 (2008-02-23)
-----------------
-* Change poweroff method to reboot(RB_POWER_OFF) (Metalshark)
-* Remove duplicate unionctl() reimplementation error
-* Fix string termination in path creation
-* Mount /var/lock and /var/run as tmpfs
-
-
-0.2 (2008-02-19)
-----------------
-* replace system("touch") with touch() in finit-mod (Metalshark)
-* disable NO_HCTOSYS by default to match stock Eeepc kernel
-* drop system("rm -f") to clean /tmp, its a fresh mounted tmpfs
-* write ACPI sleep state to /sys/power/state instead of /proc/acpi/sleep
-  (Metalshark)
-* use direct calls to set loopback instead of system("ifconfig")
-* replace system("cat") and system("dd") with C implementation
-* moved finit-mod and finit-alt helpers to helpers.c
-* replace system("echo;cat") to draw shutdown splash with C calls
-
-
-0.1 (2008-02-14)
-----------------
-* initial release
-
-
-.. Local Variables:
-..  mode: rst
-..  version-control: t
-.. End:

README

@@ -1 +1 @@
-README.rst
+README.md

README.md

@@ -0,0 +1,468 @@
+Finit | Fast & Extensible init for Linux
+========================================
+[![Build Status](https://travis-ci.org/troglobit/finit.png?branch=master)](https://travis-ci.org/troglobit/finit)
+[![Coverity Scan Status](https://scan.coverity.com/projects/3545/badge.svg)](https://scan.coverity.com/projects/3545)
+
+![Original Finit homepage image](images/finit.jpg "Finit in action!")
+
+Table of Contents
+-----------------
+
+* [Introduction](#introduction)
+* [Features](#features)
+* [/etc/finit.conf](#etcfinitconf)
+* [/etc/finit.d](#etcfinitd)
+* [Bootstrap](#bootstrap)
+* [Runlevels](#runlevels)
+* [Hooks, Callbacks & Plugins](#hooks-callbacks--plugins)
+* [Rebooting and Halting](#rebooting-and-halting)
+* [Building](#building)
+* [Running](#running)
+* [Debugging](#debugging)
+* [Origin & References](#origin--references)
+
+
+Introduction
+------------
+
+Init is the first process to run once a UNIX kernel has booted, it
+always has PID 1 and is responsible for starting up the rest of the
+system.  Finit is plugin-based with built in [process supervision][1]
+similar to that of D.J. Bernstein's [daemontools][2] and Gerrit Pape's
+[runit][3].  The main focus of Finit is on small and embedded GNU/Linux
+systems, yet fully functional on standard server and desktop
+installations as well.
+
+Traditional [SysV init][4] style systems are scripted.  For low-resource
+embedded systems this can be quite resource intensive and cause longer
+boot times.  Finit is optimized to reduce context switches and forking
+of processes to provide a very basic bootstrap written entirely in C.
+Hence, there is no `/etc/init.d/rcS` script, or similar, but instead a
+human-readable `/etc/finit.conf`.  This file details what kernel modules
+to load, programs to run and daemons to supervise.
+
+The command line arguments given in `/etc/finit.conf` to each service
+provide a default.  Each service can register callbacks, using plugins,
+to override and modify the behavior to suit the current runlevel and
+system configuration.  For instance, before starting a heavily resource
+intensive service like IPsec or OpenVPN, a callback can check if the
+outbound interface is up and has an IP address, or just check if the
+service is disabled -- much like what a SysV init start script usually
+does.
+
+See [TroglOS][9] for an example of how to boot a small embedded system
+with Finit.
+
+
+Features
+--------
+
+**Process Supervision**
+
+Start, monitor and restart services if they fail.
+
+**Runlevels**
+
+Runlevels is optional in Finit, but support for [SysV runlevels][5] is
+available if needed.  All services in runlevel S(1) are started first,
+followed by the desired run-time runlevel.  Runlevel S can be started in
+sequence by using `run [S] cmd`.  Changing runlevels at runtime is done
+like any other init, e.g. <kbd>init 4</kbd>.
+
+**Plugins**
+
+Finit plugins can be either *boot hooks* into different stages of the
+boot process or *service callbacks*, or both.  A basic set of plugins
+that extend and modify the basic behavior are bundled.  See examples in
+the `plugins/` directory.
+
+Plugin capabilities:
+
+* Service callbacks -- modify service arguments, run/restart/stop
+* Task/Run callbacks -- a one-shot commands, executed in sequence
+* Hooks -- hook into the boot at predefined points to extend finit
+* I/O -- listen to external events and control finit behavior/services
+
+Extensions and functionality not purely related to what an `/sbin/init`
+needs to start a system are available as a set of plugins that either
+hook into the boot process or respond to various I/O.
+
+
+/etc/finit.conf
+---------------
+
+Contrary to most other script based init alternatives ([SysV init][4],
+[upstart][6], [systemd][7], [OpenRC][8], etc.)  Finit reads its entire
+configuration from `/etc/finit.conf`.
+
+Syntax:
+
+* `check <DEV>`
+
+  Run fsck on a file system before mounting it
+
+* `module <MODULE>`
+
+  Load a kernel module, with optional arguments
+
+* `network <PATH>`
+
+  Script or program to bring up networking, with optional arguments
+
+* `runlevel <N>`
+
+  N is the runlevel number 1-9, where 6 is reserved for reboot.
+
+  Default is 2.
+
+* `run [LVLS] /path/to/cmd ARGS -- Optional description`
+
+  One-shot command to run in sequence when entering a runlevel, with
+  optional arguments and description.  This command is guaranteed to be
+  completed before running the next command.
+
+* `task [LVLS] /path/to/cmd ARGS -- Optional description`
+
+  One-shot like 'run', but starts in parallel with the next command
+
+* `service [LVLS] /path/to/daemon ARGS -- Optional description`
+
+  Service, or daemon, to be monitored and automatically restarted if it
+  exits prematurely.  Please note that you often need to provide a
+  --foreground or --no-background argument to most daemons to prevent
+  them from forking off to the background.
+
+* `runparts <PATH>`
+
+  Call run-parts(8) on a directory other than default ``/etc/finit.d``
+
+* `include <CONF>`
+
+  Include another configuration file, ``/etc/finit.d``, or runparts path
+  is prepended to file if the file is not found or an absolute path is
+  not given
+
+* `tty [LVLS] <DEV | /bin/sh>`
+
+  Start a getty on the given TTY device, in the given runlevels.  When
+  no tty setting is given in `finit.conf`, or if `/bin/sh` is given as
+  argument instead of a device path, a single shell is started on the
+  default console.  Useful for really bare-bones systems
+
+  See `finit.h` for the `#define GETTY` that is called, along with the
+  default baud rate.
+
+* `console <DEV>`
+
+  Some embedded systems have a dedicated console port.  This command
+  tells finit to not start getty, but instead print a friendly message
+  and wait for the user to activate the console with a key press before
+  starting getty.
+
+When running <kbd>make install</kbd> no default `/etc/finit.conf` will
+be installed since system requirements differ too much.  Try out the
+Debian 6.0 example `/usr/share/doc/finit/finit.conf` configuration that
+is capable of service monitoring SSH, sysklogd, gdm and a console getty!
+
+
+/etc/finit.d
+------------
+
+At the end of the boot, when networking and all services are up, finit
+calls its built-in run-parts(8) on the `/etc/finit.d/` directory, if it
+exists.  Similar to how the `/ec/rc.local` file works in most other init
+daemons, only finit runs a directory of scripts.  This replaces the
+earlier support for a `/usr/sbin/services.sh` script in the original
+finit.
+
+
+Bootstrap
+---------
+
+1. Setup `/dev`
+2. Parse `/etc/finit.conf`
+3. Load all `.so` plugins
+4. Remount/Pivot `/` to get R+W
+5. Call 1st level hooks, `HOOK_ROOTFS_UP`
+6. Mount `/etc/fstab` and swap, if available
+7. Cleanup stale files from `/tmp/*` et al
+8. Enable SysV init signals
+9. Call 2nd level hooks, `HOOK_BASEFS_UP`
+10. Start all 'S' runlevel tasks and services
+11. Setup `/etc/sysctl.conf`
+12. Setup hostname and loopback
+13. Call `network` script, if set in `/etc/finit.conf`
+14. Call 3rd level hooks, `HOOK_NETWORK_UP`
+15. Switch to active runlevel, as set in `/etc/finit.conf`, default 2.
+    Here is where the rest of all tasks and services are started.
+16. Call 4th level hooks, `HOOK_SVC_UP`
+17. Run-parts in `/etc/finit.d`, if any
+18. Call 5th level (last) hooks, `HOOK_SYSTEM_UP`
+19. Start TTYs defined in `/etc/finit.conf`, or rescue on `/dev/console`
+20. Enter main monitor loop
+
+In (10) and (15) tasks and services defined in `/etc/finit.conf` are
+started.  Remember, all `service` and `task` stanzas are started in
+parallel and `run` in sequence, and in the order listed.  Hence, to
+emulate a SysV `/etc/init.d/rcS` one could write a long file with only
+`run` statments.
+
+Notice the five hook points that are called at various point in the
+bootstrap process.  This is where plugins can extend the boot in any way
+they please.
+
+For instance, at `HOOK_BASEFS_UP` a plugin could read an XML file from a
+USB stick, convert/copy its contents to the system's `/etc/` directory,
+well before all 'S' runlevel tasks are started.  This could be used with
+system images that are created read-only and all configuration is stored
+on external media.
+
+
+Runlevels
+---------
+
+Basic support for [runlevels](http://en.wikipedia.org/wiki/Runlevel) is
+included in Finit from v1.8.  By default all services, tasks, run
+commands and TTYs listed without a set of runlevels get a default set
+`[234]` assigned.  The default runlevel after boot is 2.
+
+To specify an allowed set of runlevels for a `service`, `run` command, `task`,
+or `tty`, add `[NNN]` to it in your `/etc/finit.conf`, like this:
+
+    service [S12345] /sbin/syslogd -n -x     -- System log daemon
+    run     [S]      /etc/init.d/acpid start -- Starting ACPI Daemon
+    task    [S]      /etc/init.d/kbd start   -- Preparing console
+    service [S12345] /sbin/klogd -n -x       -- Kernel log daemon
+    tty     [12345]  /dev/tty1
+    tty     [2]      /dev/tty2
+    tty     [2]      /dev/tty3
+    tty     [2]      /dev/tty4
+    tty     [2]      /dev/tty5
+    tty     [2]      /dev/tty6
+
+In this example syslogd is first started, in parallel, and then acpid is
+called using a conventional SysV init script.  It is called with the run
+command, meaning the following task command to start the kbd script is
+not called until the acpid init script has fully completed.  Then the
+keyboard setup script is called in parallel with klogd as a monitored
+service.
+
+Again, tasks and services are started in parallel, while run commands
+are called in the order listed and subsequent commands are not started
+until a run command has completed.
+
+Switching between runlevels can be done by calling init with a single
+argument, e.g. <kbd>init 5</kbd> switches to runlevel 5.
+
+
+Hooks, Callbacks & Plugins
+--------------------------
+
+Finit provides only the bare necessities for starting and supervising
+processes, with an emphasis on *bare* -- for your convenience it does
+however come with support for hooks, service callbacks and plugins that
+can used to extend finit with.  For your convenience a set of *optional*
+plugins are available:
+
+* *alsa-utils.so*: Restore and save ALSA sound settings on
+  startup/shutdown.
+
+* *bootmisc.so*: Setup necessary files for UTMP, tracks logins at boot.
+
+* *dbus.so*: Setup and start system message bus, D-Bus, at boot.
+
+* *hwclock.so*: Restore and save system clock from/to RTC on
+  startup/shutdown.
+
+* *initctl.so*: Extends finit with a traditional initctl functionality.
+
+* *resolvconf.so*: Setup necessary files for resolvconf at startup.
+
+* *tty.so*: Watches /dev, using inotify, for new device nodes (TTY's) to
+  start/stop getty consoles on them on demand.
+
+* *urandom.so*: Setup random seed at startup.
+
+* *x11-common.so*: Setup necessary files for X-Window.
+
+Usually you want to hook into the boot process once, simple hook plugins
+like `bootmisc.so` are great for that purpose.  They are called at each
+hook point in the boot process, useful to insert some pre-bootstrap
+mechanisms, like generating configuration files, restoring HW device
+state, etc.  Available hook points are:
+
+* `HOOK_ROOTFS_UP`: When `finit.conf` has been read and `/` has is
+  mounted -- very early
+
+* `HOOK_BASEFS_UP`: All of `/etc/fstab` is mounted, swap is available
+  and default init signals are setup
+
+* `HOOK_NETWORK_UP`: System bootstrap, runlevel S, has completed and
+  networking is up (`lo` is up and the `network` script has run)
+
+* `HOOK_SVC_UP`: All services in the active runlevel has been launched
+
+* `HOOK_SYSTEM_UP`: All services *and* everything in `/etc/finit.d`
+  has been launched
+
+* `HOOK_SHUTDOWN`: Called at shutdown/reboot, right before all
+  services are sent `SIGTERM`
+
+Plugins like `initctl.so` and `tty.so` extend finit by acting on events,
+they are called I/O plugins and are called from the finit main loop when
+`poll()` detects an event.  See the source code for `plugins/*.c` for
+more help and ideas.
+
+Callback plugins are called by finit them right before a process is
+started, or restarted if it exits.  The callback receive a pointer to
+the `svc_t` (defined in `svc.h`) of the service, with all command line
+parameters free to modify if needed.  All the callback needs to do is
+respond with one of: `SVC_STOP (0)` tells finit to *not* start the
+service, `SVC_START (1)` to start the service, or `SVC_RELOAD (2)` to
+have finit signal the process with `SIGHUP`.
+
+
+Rebooting and Halting
+---------------------
+
+Finit handles `SIGUSR1` and `SIGUSR2` for reboot and halt, and listens
+to `/dev/initctl` so system reboot and halt commands should also work.
+This latter functionality is implemented in the optional `initctl.so`
+plugin.
+
+
+Building
+--------
+
+The finit build system does not employ the GNU Configure and Build System,
+instead standard makefiles are used. The user is encouraged to make source
+code changes, using defines and conditionally building plugins instead to
+alter the behavior of finit.
+
+The following environment variables are checked by the makefiles and control
+what is built and where resulting binaries are installed.
+
+* `ROOTDIR=`: Top directory for building complete system, used in pretty
+  printing.
+
+* `VERSION=`: Defaults to the currently released version of finit,
+  e.g., 1.3 but can be overridden by packagers using this variable to
+  add a suffix or completely alter the version.
+
+* `CFLAGS=`: Default `CFLAGS` are inherited from the environment.
+
+* `CPPFLAGS=`: Default `CPPFLAGS` are inherited from the environment.
+
+* `LDFLAGS=`: Default `LDFLAGS` are inherited from the environment.
+
+* `LDLIBS=`: Default `LIBLIBS` are inherited from the environment.
+
+* `prefix=`: Base prefix path for all files, except `sbinbdir` and
+  `sysconfdir`.  Used in concert with the `DESTDIR` variable.
+
+  Defaults to `/usr`.
+
+* `sbindir=`: Path to where resulting binaries should install to. Used
+  in concert with the `DESTDIR` variable.
+
+  Defaults to `/sbin`.
+
+* `sysconfdir=`: Path to where finit configuration files should install
+  to.  Used in concert with the `DESTDIR` variable.
+
+  Defaults to `/etc`, but is currently unused.
+
+* `PLUGINS=`: List of stock finit plugins to build and install.
+
+* `plugindir=`: Absolute path to where finit should look for dynamically
+  loadable plugins at runtime.  At installation prepended by `DESTDIR`
+  and `prefix`.
+
+  Defaults to `/lib/finit/plugins`.
+
+* `DESTDIR=`: Used by packagers and distributions when building a
+  relocatable bundle of files.  Always prepended to the `prefix`
+  destination directory.
+
+**Example**
+
+First, unpack the archive:
+
+<kbd>$ tar xfJ finit-1.3.tar.xz; cd finit-1.3/</kbd>
+
+Then build and install:
+
+<kbd>$ PLUGINS="initctl.so hwclock.so" DESTDIR=/tmp/finit make install</kbd>
+
+      CC      finit.o
+      CC      conf.o
+      CC      helpers.o
+      CC      sig.o
+      CC      svc.o
+      CC      plugin.o
+      CC      strlcpy.o
+      LINK    finit
+      CC      plugins/initctl.o
+      PLUGIN  plugins/initctl.so
+      CC      plugins/hwclock.o
+      PLUGIN  plugins/hwclock.so
+      INSTALL /tmp/finit/sbin/finit
+      INSTALL /tmp/finit/lib/finit/plugins/initctl.so
+      INSTALL /tmp/finit/lib/finit/plugins/hwclock.so
+
+In this example the [finit-1.3.tar.xz][10] archive is unpacked to the
+user's home directory, built and installed to a temporary staging
+directory.  The environment variables `DESTDIR` and `PLUGINS` are
+changed to suit this particular build.
+
+
+Running
+-------
+
+The default install does not setup finit as the system default
+`/sbin/init`, neither does it setup an initial `/etc/finit.conf`.
+
+It is assumed that users of finit are competent enough to either setup
+finit as their default `/sbin/init` or alter their respective Grub,
+LOADLIN, LILO, U-Boot/Barebox or RedBoot boot loader configuration to
+give the kernel the following extra command line:
+
+    init=/sbin/finit
+
+![Finit starting Debian 6.0](images/finit-screenshot.jpg "Finit screenshot")
+
+
+Debugging
+---------
+
+Add `finit_debug`, or `--debug`, to the kernel command line to
+enable trace messages.  A console getty is always started, see the file
+`finit.h` for more useful compile-time tweaks:
+
+    init=/sbin/finit --debug
+
+
+Origin & References
+-------------------
+
+This is the continuation of the [original finit](http://helllabs.org/finit/)
+by [Claudio Matsuoka](https://github.com/cmatsuoka), which in turn was
+reverse engineered from syscalls of the
+[EeePC fastinit](http://wiki.eeeuser.com/boot_process:the_boot_process)
+-- "gaps filled with frog DNA ...".
+
+Finit is currently being developed and maintained by
+[Joachim Nilsson](http://troglobit.com) at
+[GitHub](http://github.com/troglobit/finit).  Please file bug reports, clone it,
+or send pull requests for bug fixes and proposed extensions.
+
+[1]:  https://en.wikipedia.org/wiki/Process_supervision
+[2]:  http://cr.yp.to/daemontools.html
+[3]:  http://smarden.org/runit/
+[4]:  http://en.wikipedia.org/wiki/Init
+[5]:  http://en.wikipedia.org/wiki/Runlevel
+[6]:  http://upstart.ubuntu.com/
+[7]:  http://www.freedesktop.org/wiki/Software/systemd/
+[8]:  http://www.gentoo.org/proj/en/base/openrc/
+[9]:  https://github.com/troglobit/troglos
+[10]: ftp://troglobit.com/finit/finit-1.3.tar.xz

README.rst

@@ -1,295 +0,0 @@
-==============================================================================
-                      Finit | Fast Init Replacement
-==============================================================================
-|cistatus|
-
-Finit is a small `SysV init`_ replacement with `process supervision`_
-similar to that of `daemontools`_ and `runit`_.  Its focus is on small
-and embedded GNU/Linux systems, although fully functional on standard
-server and desktop installations.  It should also work on other UNIX
-systems, but this has yet to be proven.
-
-Finit is fast because it starts services in parallel, it then supervises
-and automatically restarts them if they fail.  This can be extended upon
-with custom callbacks for all services, hooks into the boot process, or
-plugins to extend the functionality and adapt Finit to your needs.
-
-Finit is not only fast, it's arguably one of the easiest to get started
-with.  A complete system can be booted with one simple configuration
-file, ``/etc/finit.conf``, see below for syntax.
-
-
-Features
---------
-
-**Process Supervision**
-Start, monitor and restarting services if they fail.
-
-**Runlevels**
-Finit supports standard runlevels if you want, but you don't need them
-for simple installations.
-
-**Plugins**
-Extend and modify finit behavior.  See examples in plugins/ directory.
-Plugin capabilities:
-   
-* Service callbacks — modify service arguments, run/restart/stop
-* Task/Run callbacks — a one-shot commands, executed in sequence
-* Hooks — hook into the boot at predefined points to extend finit
-* I/O — listen to external events and control finit behavior/services
-
-Extensions and functionality not purely related to what an /sbin/init
-needs to start a system are available as a set of plugins that either
-hook into the boot process or respond to various I/O.
-
-
-/etc/finit.conf
----------------
-
-Contrary to most script based init alternatives (`SysV init`_, upstart_,
-systemd_, OpenRC_ and the likes) finit instead reads its configuration
-from ``/etc/finit.conf``.  Below is a brief list, see the source code
-for the full list:
-
-check <DEV>
-    Run fsck on a file system before mounting it
-
-module <MODULE>
-    Load a kernel module, with optional arguments
-
-network <PATH>
-    Script or program to bring up networking, with optional arguments
-
-runlevel <N>
-    N is the runlevel number 1-9, where 6 is reserved for reboot
-
-run [RUN_LVLS] /path/to/cmd ARGS -- Optional description
-    One-shot command to run in sequence when entering a runlevel, with
-    optional arguments and description.  This command is guaranteed to
-    be completed before running the next command.
-
-task [RUN_LVLS] /path/to/cmd ARGS -- Optional description
-    One-shot like 'run', but starts in parallel with the next command
-
-service [RUN_LVLS] /path/to/daemon ARGS -- Optional description
-    Service, or daemon, to be monitored and automatically restarted if
-    it exits prematurely.  Please note that you often need to provide
-    a --foreground or --no-background argument to most daemons to
-    prevent them from forking off to the background.
-
-runparts <PATH>
-    Call run-parts(8) on a directory other than default ``/etc/finit.d``
-
-include <CONF>
-    Include another configuration file, ``/etc/finit.d``, or runparts
-    path is prepended to file if the file is not found or an absolute
-    path is not given
-
-tty [RUN_LVLS] <DEV | /bin/sh>
-    Start a getty on the given TTY device, in the given runlevels.  When
-    no tty setting is given in ``finit.conf``, or if /bin/sh is given as
-    argument instead of a device path, a single shell is started on the
-    default console.  Useful for really bare-bones systems
-
-console <DEV>
-    Some embedded systems have a dedicated console port. This command
-    tells finit to not start getty, but instead print a friendly message
-    and wait for the user to activate the console with a key press before
-    starting getty.
-
-When running ``make install`` no default ``/etc/finit.conf`` will be
-provided since the system requirements differ too much.  Try out the
-Debian 6.0 example ``/usr/share/doc/finit/finit.conf`` configuration
-that is capable of service monitoring SSH, sysklogd, gdm and a console
-getty!
-
-
-/etc/finit.d
-------------
-
-At the end of the boot, when networking and all services are up, finit
-calls its built-in run-parts(8) on the ``/etc/finit.d/`` directory, if
-it exists.  Similar to how the ``/ec/rc.local`` file works in most other
-init daemons, only finit runs a directory of scripts.  This replaces the
-earlier support for a ``/usr/sbin/services.sh`` script in the original
-finit.
-
-
-Runlevels
----------
-
-Support for runlevels_ is included in Finit from v1.8.  By default all
-services, tasks, run commands and TTYs listed without a set of runlevels
-get a default set [234] assigned.  The default runlevel after boot is 2.
-
-To specify an allowed set of runlevels for a service, run command, task,
-or tty, add [NNN] to it in finit.conf, like this::
-
-  run     [S]      /etc/init.d/acpid start -- Starting ACPI Daemon
-  task    [S]      /etc/init.d/kbd start -- Preparing console
-  service [S12345] /sbin/klogd -n -x -- Kernel log daemon
-  tty     [12345]  /dev/tty1
-  tty     [2]      /dev/tty2
-  tty     [2]      /dev/tty3
-  tty     [2]      /dev/tty4
-  tty     [2]      /dev/tty5
-  tty     [2]      /dev/tty6
-
-In this example acpid is started once at bootstrap using a conventional
-SysV init script.  Here the run command was used, meaning the following
-task command is not run until the init script has fully completed.
-
-Tasks and services are started in parallel, while run commands are run
-in the order listed and subsequent commands are not started until a run
-command has completed.
-
-Existing finit.conf files that lack runlevel setting will get a default
-runlevel assigned, [234].
-
-Switching between runlevels can be done by calling init with a single
-argument, e.g., 'init 5' switches to runlevel 5.
-
-
-Rebooting and Halting
----------------------
-
-Finit handles SIGUSR1 and SIGUSR2 for reboot and halt, and listens to
-``/dev/initctl`` so standard Linux reboot and halt commands should also
-work.
-
-
-Building
---------
-
-The finit build system does not employ the GNU Configure and Build System,
-instead standard makefiles are used. The user is encouraged to make source
-code changes, using defines and conditionally building plugins instead to
-alter the behavior of finit.
-
-The following environment variables are checked by the makefiles and control
-what is built and where resulting binaries are installed.
-
-**ROOTDIR=**
-   Top directory for building complete system, used in pretty printing
-
-**VERSION=**
-   Defaults to the currently released version of finit, e.g., 1.3 but can
-   be overridden by packages to add a suffix or completely alter the version.
-
-**CFLAGS=**
-   Standard CFLAGS are inherited from the build environment.
-
-**CPPFLAGS=**
-   Standard CPPFLAGS are inherited from the build environment.
-
-**LDFLAGS=**
-   Standard LDFLAGS are inherited from the build environment.
-
-**LDLIBS=**
-   Standard LIBLIBS are inherited from the build environment.
-
-**prefix=**
-   Base prefix path for all files, except ``sbinbdir`` and ``sysconfdir``.
-   Used in concert with the ``DESTDIR`` variable. Defaults to ``/usr``
-
-**sbindir=**
-   Path to where resulting binaries should install to. Used in concert
-   with the ``DESTDIR`` variable. Defaults to ``/sbin``
-
-**sysconfdir=**
-   Path to where finit configuration files should install to. Used in
-   concert with the ``DESTDIR`` variable.  Defaults to ``/etc``, but is
-   currently unused.
-
-**PLUGINS=**
-   List of stock finit plugins to build and install.
-
-**plugindir=**
-   Absolute path to where finit should look for dynamically loadable plugins
-   at runtime. At installation prepended by ``DESTDIR`` and ``prefix``.
-   Defaults to ``/lib/finit/plugins``
-
-**DESTDIR=**
-   Used by packagers and distributions when building a relocatable
-   bundle of files. Always prepended to the ``prefix`` destination
-   directory.
-
-**Example**::
-
-  $ tar xfJ finit-1.3.tar.xz
-  $ PLUGINS="initctl.so hwclock.so" DESTDIR=/tmp/finit/dst \
-    make -C finit-1.3/ clean install
-  make: Entering directory `/home/troglobit/finit-1.3'
-    CC      finit.o
-    CC      conf.o
-    CC      helpers.o
-    CC      sig.o
-    CC      svc.o
-    CC      plugin.o
-    CC      strlcpy.o
-    LINK    finit
-    CC      plugins/initctl.o
-    PLUGIN  plugins/initctl.so
-    CC      plugins/hwclock.o
-    PLUGIN  plugins/hwclock.so
-    INSTALL /tmp/finit/dst/sbin/finit
-    INSTALL /tmp/finit/dst/lib/finit/plugins/initctl.so
-    INSTALL /tmp/finit/dst/lib/finit/plugins/hwclock.so
-  make: Leaving directory `/home/troglobit/finit-1.3'
-
-In this example the `finit-1.3.tar.xz`_ archive is unpacked to the
-user's home directory, built and installed to a temporary staging
-directory.  The environment variables ``DESTDIR`` and ``PLUGINS`` are
-changed to suit this particular build.
-
-
-Running
--------
-
-The default install does not setup finit as the system default
-``/sbin/init``, neither does it setup an initial ``/etc/finit.conf``.
-
-It is assumed that users of finit are competent enough to either setup
-finit as their default ``/sbin/init`` or alter their respective Grub,
-LOADLIN, LILO, U-Boot/Barebox or RedBoot boot loader configuration to
-give the kernel the following extra command line::
-
-  init=/sbin/finit
-
-
-Debugging
----------
-
-Add ``finit_debug``, or ``--debug``, to the kernel command line to
-enable trace messages.  A console getty is always started, see the file
-``finit.h`` for more useful compile-time tweaks::
-
-  init=/sbin/finit --debug
-
-
-Contact
--------
-
-This is the continuation of the `original finit`_ by Claudio Matsuoka,
-which in turn was reverse engineered from syscalls of the `EeePC
-fastinit`_ -- "gaps filled with frog DNA ...".  It is currently being
-developed and maintained by `Joachim Nilsson`_ at `GitHub`_.  Please
-file bug reports, clone it, or send pull requests for bug fixes and
-proposed extensions.
-
-.. _`SysV init`: https://en.wikipedia.org/wiki/Init
-.. _`Joachim Nilsson`: http://troglobit.com
-.. _GitHub: http://github.com/troglobit/finit
-.. _`process supervision`: https://en.wikipedia.org/wiki/Process_supervision
-.. _`daemontools`: http://cr.yp.to/daemontools.html
-.. _`runit`: http://smarden.org/runit/
-.. _`original finit`: http://helllabs.org/finit/
-.. _`EeePC fastinit`: http://wiki.eeeuser.com/boot_process:the_boot_process
-.. _upstart: http://upstart.ubuntu.com/
-.. _runlevels: http://en.wikipedia.org/wiki/Runlevel
-.. _systemd: http://www.freedesktop.org/wiki/Software/systemd/
-.. _openrc: http://www.gentoo.org/proj/en/base/openrc/
-.. _`finit-1.3.tar.xz`: ftp://troglobit.com/finit/finit-1.3.tar.xz
-.. |cistatus| image:: https://travis-ci.org/troglobit/finit.png?branch=master
-                      :target: https://travis-ci.org/troglobit/finit
-

TODO

@@ -1 +1 @@
-TODO.rst
+TODO.md

TODO.md

@@ -0,0 +1,165 @@
+Goals of Finit
+==============
+
+The intent of finit is to monitor not just processes, but to supervise
+an entire system and the behavior of certain processes that declare
+themselves to be finit compliant.  Similar to launchd, the goal of
+finit is to be a replacement for:
+
+* init
+* inetd
+* crond
+* watchdogd
+
+A small and simple replacement, primarily for embedded systems, with a
+very low dependency on external packages.
+
+General
+-------
+
+* Add support for `init <q | reload-configuration>` and `SIGHUP` to
+  have finit reload its `finit.conf`, but also
+* Add support for inotify to automatically reload `finit.conf`
+* Implement `initctl stop|start|restart|reload|status <SVC>` and
+  `service <SVC> stop|start|restart|reload|status` on top
+* Add PRE and POST hooks for when switching between runlevels
+* Add support for `init -v,--version | version`
+* Cleanup move sources from top-level directory to `src/` and `include/`
+* Make sure to install `queue.h` to `$(PREFIX)/include/finit/queue.h`
+* Move `finit.conf` "check" command to plugin which checks `/etc/fstab`
+  instead.  This is the de-facto practice.  But keep the check command
+  for really low-end systems w/o `/etc/fstab`.
+
+
+Init
+----
+
+Finit in itself is not SysV Init compatible, it doesn't use `/etc/rc.d`
+and `/etc/inet.d` scripts to boot the system.  However, a plausible way
+to achieve compatibility would be to add a plugin to finit which reads
+`/etc/inittab` to be able to start standard Linux systems.
+
+
+Inetd
+-----
+
+Simple way of running Internet services on demand, like the old inetd:
+
+    inetd PROTO/SERVICE <wait|nowait> [@USER[:GROUP]] /path/to/daemon args
+
+Examples:
+
+    # Inetd services, launched on demand
+    inetd tcp/ssh nowait [2345] @root:root /usr/sbin/sshd -i
+
+In keeping with the finit tradition, an optional callback can be setup
+to each inetd service.  When a client connects the finit will call the
+callback with a `struct in_pktinfo` argument which the callback then can
+allowed or deny.
+
+Alternatively, borrowing from TCP wrappers by Wietse Venema, a set of
+`allow` and `deny` directives can be added to `finit.conf` to control
+inetd services.  It could be what IP addreses, networks or interfaces
+are allowed to connect to the given inetd services.  To start with the
+easiest (and what we need for WeOS at Westermo) is allow/deny per iface.
+
+    # Disable access to SSH
+    deny  ssh all
+    # Allow SSH connections originating from eth0
+    allow ssh eth0
+
+Another option, to further extend the Inetd capabilities, is a separate
+`finetd.conf` to list services.  This would be beneficial when running
+an SSH service on different ports on different interfaces:
+
+    # Run SSH on port 22 on all interfaces except upstream
+    tcp ssh {
+       listen = *, !wan0
+       exec   = dropbear -i
+    }
+    
+    # Run SSH on non-standard port 222 for upstream interface
+    tcp 222 {
+       listen = wan0
+       exec   = dropbear -i
+       wait   = yes
+    }
+    
+    # Run TFTP service on all interfaces except upstream interface
+    udp tftp {
+       listen = *, !wan0
+       exec   = uftpd -i -t
+       user   = root
+    }
+
+Syntax very similar to [xinetd](http://en.wikipedia.org/wiki/Xinetd)
+
+
+Crond
+-----
+
+Requirements are quite rudimentary, basic cron functionality, mainly
+system-level timed periodic tasks:
+
+* Periodically run a task, in a matching runlevel
+* Optionally run as non-root (`crontab -e` as operator)
+
+Proposed syntax:
+
+    # Crontab
+    cron @YY-mm-ddTHH:MM [LVLS] /path/to/cmd [ARGS] -- Optional descr
+    
+    # One-shot 'at' command
+    at @YY-mm-ddTHH:MM [LVLS] /path/to/cmd [ARGS] -- Optional descr
+
+Notice the ISO date in notation.  The runlevels is extra filtering
+sugar.  E.g., if cron service is only allowed in runlevels two or three
+it will not start if system currently is in runlevel four.
+
+To run a command as another user the `.conf` file must have a that
+owner.  E.g., `/etc/finit.d/extra.conf` may be owned by operator and
+only hold `cron ...` lines.
+
+What would be extremely useful is if `initctl`, or a homegrown `at`,
+could support the basic functionality of the `at` command directly from
+the shell -- that way setting up one-time jobs would not entail
+re-reading `/etc/finit.conf`
+
+
+Watchdog
+--------
+
+Support for monitoring the health of the system and its processes.
+
+* Add support for a `/dev/watchdog` plugin to replace `watchdogd`
+* Integrate system supervisor to optionally reboot the system when a
+  process stops responding, or when a respawn limit has been reached,
+  as well as when system load gets too high.
+* API for processes to register with the watchdog.
+  - Deeper monitoring of a process main loop
+  - If a process is not heard from within its subscribed period time
+    reboot system or restart process.
+* Separate `/etc/watchdog.conf` configuration file, or a perhaps
+  support for `/etc/finit.d/PLUGIN.conf`?
+* Support enable/disable watchdog features:
+  - Supervise processes,
+  - CPU loadavg,
+  - Watch for file descriptor leaks,
+  - etc.
+
+
+Documentation
+-------------
+
+* Write man pages for finit and `finit.conf`, steal from the excellent
+  `pimd` man pages ...
+* Update Debian `finit.conf` example with runlevels, `tty/console` and
+  dependency handling for Debian 8 (the dreaded systemd release).
+
+
+Investigation
+-------------
+
+* [FHS changes](http://askubuntu.com/questions/57297/why-has-var-run-been-migrated-to-run)
+  affecting runtime status, plugins, etc.
+

TODO.rst

@@ -1,118 +0,0 @@
-==============================================================================
-                                    TODO
-==============================================================================
-
-Unsorted TODO list of features and points of investigation that could be
-useful for improving finit.  But what is an improvement to finit?  Well,
-similiar to launchd, the goal of finit is to be a FAST replacement for:
-
-* init
-* inetd
-* crond
-* watchdogd
-
-The main goal is to be FAST. Secondary goals are to be: small, simple
-and with a very low dependency on external packages.
-
-Inetd
------
-Simple way of running Internet services on demand, like the old inetd::
-
-    inetd SVC [RUNLVL] /path/to/daemon args -- description
-
-Example::
-
-    # Inetd services, launched on demand
-    inetd ssh [2345] /usr/sbin/sshd -i -- SSH Daemon
-
-In keeping with the finit tradition, an optional callback can be setup
-to each inetd service.  When a client connects the finit will call the
-callback with a `struct in_pktinfo` argument which the callback then can
-allowed or deny.
-
-
-Priority
---------
-The intent of finit is to monitor not just processes, but also to
-be able to supervise the entire system and the behavior of certain
-processes that declare themselves to be finit compliant.
-
-* Integrate the ingenious libev to handle all events: signals, polling
-  fd's, etc.  Because "Event driven software improves concurrency" --
-  Dave Zarzycki, Apple.  See the `launchd video`_ for more info!
-* Add support for a /dev/watchdog plugin to replace watchdogd
-* Integrate watchdog plugin with process/system supervisor to optionally
-  reboot the system when a process stops responding, or when a respawn
-  limit has been reached, as well as when system load gets too high.
-
-
-Configuration
--------------
-* Add support for "init <q | reload-configuration>" and SIGHUP to
-  reload finit.conf, but also
-* Add support for inotify to automatically reload finit.conf
-
-
-Runlevels
----------
-* Add support for "runlevel N" to finit.conf
-* Improve support for runlevels: startup, running (services from
-  finit.conf), and shutdown as well as hooks when switching RL, startup
-  at RL 1 and a default run level.
-* Implement initctl stop|start|restart|reload|status <SVC> and service
-  <SVC> stop|start|restart|reload|status on top
-* Add PRE and POST hooks for when changing runlevels
-* SysV init in Debian uses an rcS.d/ for scripts that should run once at
-  boot.  These scripts are run before the actual runlevel, which is set
-  in inittab.  We could use "task [S]" and "run [S]" (below) for this.
-* Add support for a new runlevel 'S' that is started before all other
-  services in the selected runlevel.
-
-
-Services and Tasks
-------------------
-Both the "task" and "boot" stanzas below are like "service", share the
-same mechanism for registering callbacks.  These callbacks can be used
-to check a configuration db and return 1 (RUN), 2 (STOP), or 3 (RELOAD).
-
-* Add support for "task [RUNLVL] ..." similar to services, but one-shot.
-* Add support for "run [RUNLVL] ..." similar to task, but waits for
-  completion before continuing with the next task/service
-* Add support for service/task/run dependencies
-* Add support for "init list" to show running services
-
-It is tempting to say that a task called at runlevel S would be a
-blocking call, like run, but there are likely use-cases when you want to
-call on-shot tasks in parallell with something else, even at boot. Hence
-the differentiation between "task" and "run", which are essentially the
-same, except for the "pause and wait for completion" that "run" has.
-
-
-Miscellaneous
--------------
-* Add support for "init -v,--version | version"
-* Cleanup move sources from top-level directory to src/ and include/
-* Make sure to install queue.h to $(PREFIX)/include/finit/queue.h
-* Move finit.conf "check" command to plugin which checks /etc/fstab
-  instead. This is the de-facto practise.  But keep the check command
-  for really low-end systems w/o /etc/fstab.
-
-
-Documentation
--------------
-* Write man pages for finit and finit.conf, steal from pimd man pages...
-* Update Debian finit.conf example with runlevels, tty/console and
-  dependency handling
-
-
-Investigation
--------------
-* `FHS changes`_ affecting runtime status, plugins, etc.
-
-.. _`launchd video`: http://www.youtube.com/watch?v=cD_s6Fjdri8
-.. _`FHS changes`: http://askubuntu.com/questions/57297/why-has-var-run-been-migrated-to-run
-..
-.. Local Variables:
-..  mode: rst
-..  version-control: t
-.. End:

finit.c

@@ -131,27 +131,6 @@ static int client(int argc, char *argv[])
 	return 0;
 }
 
-static int run_loop(void)
-{
-	int delay = DELAY_TTY ?: 1;
-
-	_d("Entering main loop ...");
-	while (1) {
-		svc_monitor();
-		plugin_monitor();
-
-		/* Delayed start of TTYs to let the system stabilize
-		 * after switching runlevels. */
-		if (delay) {
-			if (--delay == 0)
-				tty_runlevel(runlevel);
-			continue;
-		}
-	}
-
-	return 0;
-}
-
 static void banner(void)
 {
 	delline();
@@ -160,6 +139,8 @@ static void banner(void)
 
 int main(int argc, char* argv[])
 {
+	uev_ctx_t ctx;
+
 	if (getpid() != 1)
 		return client(argc, argv);
 
@@ -173,6 +154,11 @@ int main(int argc, char* argv[])
 	 */
 	sig_init();
 
+	/*
+	 * Initalize event context.
+	 */
+	uev_init(&ctx);
+
 	/*
 	 * Mount base file system, kernel is assumed to run devtmpfs for /dev
 	 */
@@ -181,8 +167,8 @@ int main(int argc, char* argv[])
 	mount("none", "/proc", "proc", 0, NULL);
 	mount("none", "/proc/bus/usb", "usbfs", 0, NULL);
 	mount("none", "/sys", "sysfs", 0, NULL);
-	mkdir("/dev/pts", 0755);
-	mkdir("/dev/shm", 0755);
+	makedir("/dev/pts", 0755);
+	makedir("/dev/shm", 0755);
 	mount("none", "/dev/pts", "devpts", 0, "gid=5,mode=620");
 	mount("none", "/dev/shm", "tmpfs", 0, NULL);
 	umask(022);
@@ -208,7 +194,7 @@ int main(int argc, char* argv[])
 	 * hook on to.
 	 */
 	print_desc("Loading plugins", NULL);
-	print_result(plugin_load_all(PLUGIN_PATH));
+	print_result(plugin_load_all(&ctx, PLUGIN_PATH));
 
 	/*
 	 * Mount filesystems
@@ -232,7 +218,7 @@ int main(int argc, char* argv[])
 	run_interactive("rm -rf /tmp/* /var/run/* /var/lock/*", "Cleanup temporary directories");
 
 	/* Base FS up, enable standard SysV init signals */
-	sig_setup();
+	sig_setup(&ctx);
 
 	_d("Base FS up, calling hooks ...");
 	plugin_run_hooks(HOOK_BASEFS_UP);
@@ -250,7 +236,7 @@ int main(int argc, char* argv[])
 	run("/sbin/sysctl -e -p /etc/sysctl.conf >/dev/null");
 
 	/* Set initial hostname. */
-	set_hostname(hostname);
+	set_hostname(&hostname);
 
 	ifconfig("lo", "127.0.0.1", "255.0.0.0", 1);
 	if (network)
@@ -279,10 +265,13 @@ int main(int argc, char* argv[])
 	/* Hooks that should run at the very end */
 	plugin_run_hooks(HOOK_SYSTEM_UP);
 
+	/* Start TTYs */
+	tty_runlevel(runlevel);
+
 	/*
 	 * Enter main loop to monior /dev/initctl and services
 	 */
-	return run_loop();
+	return uev_run(&ctx, 0);
 }
 
 /**

finit.h

@@ -65,9 +65,6 @@
 # define DEFHOST		"noname"
 #endif
 
-/* Delay start of GETTY at boot. Must be > 0 */
-#define DELAY_TTY		2
-
 #define CMD_SIZE		256
 #define LINE_SIZE		1024
 #define BUF_SIZE		4096

helpers.c

@@ -131,31 +131,31 @@ void ifconfig(char *ifname, char *addr, char *mask, int up)
  */
 pid_t pidfile_read(char *pidfile)
 {
-   pid_t pid = 0;
-   char buf[16];
-   FILE *fp;
+	pid_t pid = 0;
+	char buf[16];
+	FILE *fp;
 
-   if (!pidfile) {
-      errno = EINVAL;
-      return -1;
-   }
+	if (!pidfile) {
+		errno = EINVAL;
+		return -1;
+	}
 
-   if (!fexist(pidfile))
-      return -1;
+	if (!fexist(pidfile))
+		return -1;
 
-   fp = fopen(pidfile, "r");
-   if (!fp)
-      return -1;
+	fp = fopen(pidfile, "r");
+	if (!fp)
+		return -1;
 
-   if (fgets(buf, sizeof(buf), fp)) {
-      errno = 0;
-      pid = strtoul(buf, NULL, 0);
-      if (errno)
-	      pid = 0;		/* Failed conversion. */
-   }
-   fclose(fp);
+	if (fgets(buf, sizeof(buf), fp)) {
+		errno = 0;
+		pid = (pid_t)strtol(buf, NULL, 10);
+		if (errno)
+			pid = 0;		/* Failed conversion. */
+	}
+	fclose(fp);
 
-   return pid;
+	return pid;
 }
 
 /**
@@ -270,12 +270,15 @@ int procname_kill(char *name, int signo)
 	DIR *dir;
 	struct dirent *entry;
 
-	dir = opendir("/proc");
-	if (!dir || !name) {
+	if (!name) {
 		errno = EINVAL;
 		return 0;
 	}
 
+	dir = opendir("/proc");
+	if (!dir)
+		return 0;
+
 	while ((entry = readdir(dir)) != NULL) {
 		/* Skip non-process entries in /proc */
 		if (!isdigit(*entry->d_name))
@@ -404,7 +407,6 @@ int complete(char *cmd, int pid)
 int run(char *cmd)
 {
 	int status, result, i = 0;
-	FILE *fp;
 	char *args[NUM_ARGS + 1], *arg, *backup;
 	pid_t pid;
 
@@ -444,17 +446,18 @@ int run(char *cmd)
 		return 1;
 	}
 
-	fp = fopen("/dev/null", "w");
-	pid = fork();
+	pid = vfork();
 	if (0 == pid) {
 		int i;
+		FILE *fp;
 		struct sigaction sa;
 
 		/* Reset signal handlers that were set by the parent process */
 		for (i = 1; i < NSIG; i++)
 			DFLSIG(sa, i, 0);
 
-		/* Redirect stdio if the caller requested so. */
+		/* Always redirect stdio for run() */
+		fp = fopen("/dev/null", "w");
 		if (fp) {
 			int fd = fileno(fp);
 
@@ -463,18 +466,20 @@ int run(char *cmd)
 			dup2(fd, STDERR_FILENO);
 		}
 
+		sig_unblock();
 		execvp(args[0], args);
+
 		_exit(1); /* Only if execv() fails. */
 	} else if (-1 == pid) {
 		_pe("%s", args[0]);
+		free(backup);
+
 		return -1;
 	}
 
 	status = complete(args[0], pid);
 	if (-1 == status) {
-		if (fp) fclose(fp);
 		free(backup);
-
 		return 1;
 	}
 
@@ -489,7 +494,6 @@ int run(char *cmd)
 				     * change their return code accordingly. --Jocke */
 	}
 
-	if (fp) fclose(fp);
 	free(backup);
 
 	return result;
@@ -500,27 +504,49 @@ int run_interactive(char *cmd, char *fmt, ...)
 	int status, oldout = 1, olderr = 2;
 	char line[LINE_SIZE];
 	va_list ap;
-	FILE *fp = tmpfile();
+	FILE *fp;
 
-	va_start(ap, fmt);
-	vsnprintf(line, sizeof(line), fmt, ap);
-	va_end(ap);
+	if (!cmd) {
+		errno = EINVAL;
+		return 1;
+	}
+
+	if (fmt) {
+		va_start(ap, fmt);
+		vsnprintf(line, sizeof(line), fmt, ap);
+		va_end(ap);
 
-	if (fmt)
 		print_desc("", line);
+	}
+
+	/* Redirect output from cmd to a tempfile */
+	fp = tmpfile();
 	if (fp && !debug) {
 		oldout = dup(STDOUT_FILENO);
 		olderr = dup(STDERR_FILENO);
 		dup2(fileno(fp), STDOUT_FILENO);
 		dup2(fileno(fp), STDERR_FILENO);
 	}
+
+	/* Run cmd ... */
 	status = run(cmd);
+
+	/* Restore stderr/stdout */
 	if (fp && !debug) {
-		dup2(oldout, STDOUT_FILENO);
-		dup2(olderr, STDERR_FILENO);
+		if (oldout >= 0) {
+			dup2(oldout, STDOUT_FILENO);
+			close(oldout);
+		}
+		if (olderr >= 0) {
+			dup2(olderr, STDERR_FILENO);
+			close(olderr);
+		}
 	}
+
 	if (fmt)
 		print_result(status);
+
+	/* Dump any results of cmd on stderr after we've printed [ OK ] or [FAIL]  */
 	if (fp && !debug) {
 		size_t len, written;
 
@@ -529,21 +555,21 @@ int run_interactive(char *cmd, char *fmt, ...)
 			len     = fread(line, 1, sizeof(line), fp);
 			written = fwrite(line, len, sizeof(char), stderr);
 		} while (len > 0 && written == len);
-		fclose(fp);
 	}
 
+	if (fp)
+		fclose(fp);
+
 	return status;
 }
 
 pid_t run_getty(char *cmd, char *args[], int console)
 {
-	pid_t pid = fork();
+	pid_t pid = vfork();
 
 	if (!pid) {
-		int i, fd;
+		int fd;
 		char c;
-		sigset_t nmask;
-		struct sigaction sa;
 
 		if (console) {
 			/* Detach from initial controlling TTY */
@@ -564,13 +590,13 @@ pid_t run_getty(char *cmd, char *args[], int console)
 
 			prctl(PR_SET_NAME, "console", 0, 0, 0);
 		}
-		sigemptyset(&nmask);
-		sigaddset(&nmask, SIGCHLD);
-		sigprocmask(SIG_UNBLOCK, &nmask, NULL);
 
-		/* Reset signal handlers that were set by the parent process */
-		for (i = 1; i < NSIG; i++)
-			DFLSIG(sa, i, 0);
+		sig_unblock();
+
+		setsid();
+
+		if (ioctl(STDIN_FILENO, TIOCSCTTY, 1) < 0)
+			_pe("Failed TIOCSCTTY");
 
 		while (!fexist(SYNC_SHUTDOWN)) {
 			static const char msg[] = "\nPlease press Enter to activate this console.";
@@ -581,7 +607,7 @@ pid_t run_getty(char *cmd, char *args[], int console)
 			}
 
 			if (console) {
-				i = write(STDERR_FILENO, msg, sizeof(msg));
+				(void)write(STDERR_FILENO, msg, sizeof(msg));
 				while (read(STDIN_FILENO, &c, 1) == 1 && c != '\n')
 					continue;
 			}
@@ -603,7 +629,7 @@ pid_t run_getty(char *cmd, char *args[], int console)
 int run_parts(char *dir, char *cmd)
 {
 	struct dirent **e;
-	int i, num;
+	volatile int i, num;
 
 	num = scandir(dir, &e, NULL, alphasort);
 	if (num < 0) {
@@ -643,9 +669,10 @@ int run_parts(char *dir, char *cmd)
 		}
 		args[j++] = NULL;
 
-		pid = fork();
+		pid = vfork();
 		if (!pid) {
 			_d("Calling %s ...", path);
+			sig_unblock();
 			execv(path, args);
 			exit(0);
 		}
@@ -698,26 +725,33 @@ void do_sleep(unsigned int sec)
 		;
 }
 
-void set_hostname(char *hostname)
+void set_hostname(char **hostname)
 {
 	FILE *fp;
 
-	_d("Set hostname: %s", hostname);
-	if ((fp = fopen("/etc/hostname", "r")) != NULL) {
+	_d("Set hostname: %s", *hostname);
+	fp = fopen("/etc/hostname", "r");
+	if (fp) {
 		struct stat st;
 
-		fstat(fileno(fp), &st);
-		hostname = realloc(hostname, st.st_size);
-		if (!hostname)
+		if (fstat(fileno(fp), &st)) {
+			fclose(fp);
 			return;
+		}
 
-		fgets(hostname, st.st_size, fp);
-		chomp(hostname);
+		*hostname = realloc(*hostname, st.st_size);
+		if (!*hostname) {
+			fclose(fp);
+			return;
+		}
+
+		fgets(*hostname, st.st_size, fp);
+		chomp(*hostname);
 		fclose(fp);
 	}
 
-	if (hostname)
-		sethostname(hostname, strlen(hostname));
+	if (*hostname)
+		sethostname(*hostname, strlen(*hostname));
 }
 
 /**

helpers.h

@@ -42,7 +42,16 @@
 
 
 #ifndef touch
-# define touch(x) mknod((x), S_IFREG|0644, 0)
+# define touch(x) do { if (mknod((x), S_IFREG|0644, 0) && errno != EEXIST) _pe("Failed creating %s", x); } while (0)
+#endif
+#ifndef makedir
+# define makedir(x, p) do { if (mkdir(x, p) && errno != EEXIST) _pe("Failed creating directory %s", x); } while (0)
+#endif
+#ifndef makefifo
+# define makefifo(x, p) do { if (mkfifo(x, p) && errno != EEXIST) _pe("Failed creating FIFO %s", x); } while (0)
+#endif
+#ifndef erase
+# define erase(x) do { if (remove(x) && errno != ENOENT) _pe("Failed removing %s", x); } while (0)
 #endif
 #ifndef chardev
 # define chardev(x,m,maj,min) mknod((x), S_IFCHR|(m), makedev((maj),(min)))
@@ -101,7 +110,7 @@ void    chomp           (char *str);
 void    do_sleep        (unsigned int sec);
 int     getuser         (char *username);
 int     getgroup        (char *group);
-void    set_hostname    (char *hostname);
+void    set_hostname    (char **hostname);
 
 int     complete        (char *cmd, int pid);
 int     run             (char *cmd);

libite/copyfile.c

@@ -344,7 +344,7 @@ int main(void)
 		if (fexist(files[i + 2]))
 			fprintf(stderr, "OK => %s\n", files[i + 2]);
 
-		remove(files[i + 2]);
+		erase(files[i + 2]);
 		i += 3;
 	}
 
@@ -358,7 +358,7 @@ int main(void)
 		if (fexist(files[i + 2]))
 			fprintf(stderr, "OK => %s\n", files[i + 2]);
 
-		remove(files[i + 2]);
+		erase(files[i + 2]);
 		i += 3;
 	}
 

libite/dir.c

@@ -142,13 +142,13 @@ int simulate_files(int creat)
 		if (creat)
 			touch(files[i]);
 		else
-			remove(files[i]);
+			erase(files[i]);
 	}
 
 	if (creat)
 		symlink("config2.cfg", STARTUP_CONFIG);
 	else
-		remove(STARTUP_CONFIG);
+		erase(STARTUP_CONFIG);
 
 	return 0;
 }

libite/rsync.c

@@ -27,7 +27,8 @@
 #include "lite.h"
 #include "../helpers.h"
 
-static int makedir(char *buf, size_t buf_len, char *dir, char *name, mode_t mode);
+static int copy(char *src, char *dst);
+static int mdir(char *buf, size_t buf_len, char *dir, char *name, mode_t mode);
 static int prune(char *dst, char **new_files, int new_num);
 
 
@@ -58,26 +59,16 @@ int rsync(char *src, char *dst, int delete, int (*filter) (const char *file))
 	int i = 0, num = 0, result = 0;
 	char **files;		/* Array of file names. */
 
-	void copy(char *src, char *dst)
-	{
-		errno = 0;
-		copyfile(src, dst, 0, 1);
-		if (errno) {
-			if (errno == EEXIST)
-				errno = 0;
-			else
-				result++;
-		}
-	}
-
 	if (!fisdir(dst))
-		mkdir(dst, 0755);
+		makedir(dst, 0755);
 
 	if (!fisdir(src)) {
 		if (!fexist(src))
 			return 1;
 
-		copy(src, dst);
+		if (copy(src, dst))
+			result++;
+
 		return errno;
 	}
 
@@ -90,7 +81,7 @@ int rsync(char *src, char *dst, int delete, int (*filter) (const char *file))
 		else
 			ptr++;
 
-		if (makedir(dest, sizeof(dest), dst, ptr, fmode(src)))
+		if (mdir(dest, sizeof(dest), dst, ptr, fmode(src)))
 			return 1;
 		dst = dest;
 	}
@@ -103,7 +94,7 @@ int rsync(char *src, char *dst, int delete, int (*filter) (const char *file))
 			char dst2[256];
 
 			strcat(source, "/");
-			if (makedir (dst2, sizeof(dst2), dst, files[i], fmode(source))) {
+			if (mdir (dst2, sizeof(dst2), dst, files[i], fmode(source))) {
 				result++;
 				continue;
 			}
@@ -111,7 +102,9 @@ int rsync(char *src, char *dst, int delete, int (*filter) (const char *file))
 			rsync(source, dst2, delete, filter);
 			continue;	/* Next file/dir in @src to copy... */
 		}
-		copy(source, dst);
+
+		if (copy(source, dst))
+			result++;
 	}
 
 	/* We ignore any errors from the pruning, that phase albeit useful is only
@@ -128,8 +121,23 @@ int rsync(char *src, char *dst, int delete, int (*filter) (const char *file))
 	return result;
 }
 
+static int copy(char *src, char *dst)
+{
+	errno = 0;
+
+	copyfile(src, dst, 0, 1);
+	if (errno) {
+		if (errno != EEXIST)
+			return 1;
+
+		errno = 0;
+	}
+
+	return 0;
+}
+
 /* Creates dir/name @mode ... skipping / if dir already ends so. */
-static int makedir(char *buf, size_t buf_len, char *dir, char *name, mode_t mode)
+static int mdir(char *buf, size_t buf_len, char *dir, char *name, mode_t mode)
 {
 	snprintf(buf, buf_len, "%s%s%s/", dir, fisslashdir(dir) ? "" : "/", name);
 	if (mkdir(buf, mode)) {

plugin.c

@@ -36,10 +36,8 @@
 
 #define is_io_plugin(p) ((p)->io.cb && (p)->io.fd >= 0)
 
-static char         *plugpath = NULL; /* Set by first load. */
-static size_t        num_fds  = 0;
-static struct pollfd fds[MAX_NUM_FDS];
-static TAILQ_HEAD(, plugin) plugins = TAILQ_HEAD_INITIALIZER(plugins);
+static char                *plugpath = NULL; /* Set by first load. */
+static TAILQ_HEAD(, plugin) plugins  = TAILQ_HEAD_INITIALIZER(plugins);
 
 static void check_plugin_depends(plugin_t *plugin);
 
@@ -69,15 +67,8 @@ int plugin_register(plugin_t *plugin)
 
 	check_plugin_depends(plugin);
 
-	if (is_io_plugin(plugin)) {
-		if (num_fds + 1 >= MAX_NUM_FDS) {
-			num_fds = MAX_NUM_SVC;
-			errno = ENOMEM;
-			return 1;
-		}
-		num_fds++;
+	if (is_io_plugin(plugin))
 		inuse++;
-	}
 
 	if (plugin->svc.cb) {
 		svc_t *svc = svc_find(plugin->name);
@@ -159,7 +150,7 @@ plugin_t *plugin_find(char *name)
 
 	SEARCH_PLUGIN(name);
 
-	if (name[0] != '/') {
+	if (plugpath && name[0] != '/') {
 		int noext;
 		char path[CMD_SIZE];
 
@@ -189,62 +180,29 @@ void plugin_run_hooks(hook_point_t no)
 }
 
 /* Generic libev I/O callback, looks up correct plugin and calls its callback */
-static void generic_io_cb(struct pollfd *io)
+static void generic_io_cb(uev_ctx_t *UNUSED(ctx), uev_t *w, void *arg, int events)
 {
-	plugin_t *p, *tmp;
+	plugin_t *p = (plugin_t *)arg;
 
-	/* Find matching plugin, pick first matching fd */
-	PLUGIN_ITERATOR(p, tmp) {
-		if (is_io_plugin(p) && p->io.fd == io->fd) {
-			_d("Calling I/O %s from runloop...", basename(p->name));
-			p->io.cb(p->io.arg, io->fd, io->events);
+	if (is_io_plugin(p) && p->io.fd == w->fd) {
+		_d("Calling I/O %s from runloop...", basename(p->name));
+		p->io.cb(p->io.arg, w->fd, events);
 
-			/* Update fd, may be changed by plugin callback, e.g., if FIFO */
-			io->fd      = p->io.fd;
-			io->events  = p->io.flags;
-			io->revents = 0;
-			break;
-		}
-	}
-}
-
-void plugin_monitor(void)
-{
-	int ret;
-	size_t i;
-
-	while ((ret = poll(fds, num_fds, 500))) {
-		if (-1 == ret) {
-			if (EINTR == errno)
-				continue;
-
-			_e("Failed polling I/O plugin descriptors, error %d: %s",
-			   errno, strerror(errno));
-			break;
-		}
-
-		/* Traverse all I/O fds and run callbacks */
-		for (i = 0; i < num_fds; i++) {
-			if (fds[i].revents)
-				generic_io_cb(&fds[i]);
-		}
-
-		break;
+		/* Update fd, may be changed by plugin callback, e.g., if FIFO */
+		if (p->io.fd != w->fd)
+			uev_io_set (w, p->io.fd, p->io.flags);
 	}
 }
 
 /* Setup any I/O callbacks for plugins that use them */
-static void init_plugins(void)
+static void init_plugins(uev_ctx_t *ctx)
 {
-	int i = 0;
 	plugin_t *p, *tmp;
 
 	PLUGIN_ITERATOR(p, tmp) {
 		if (is_io_plugin(p)) {
 			_d("Initializing plugin %s for I/O", basename(p->name));
-			fds[i].revents = 0;
-			fds[i].events  = p->io.flags;
-			fds[i++].fd    = p->io.fd;
+			uev_io_init(ctx, &p->watcher, generic_io_cb, p, p->io.fd, p->io.flags);
 		}
 	}
 }
@@ -280,6 +238,9 @@ static int load_one(char *path, char *name)
 	snprintf(plugin, sizeof(plugin), "%s/%s%s", path, name, noext ? ".so" : "");
 
 	_d("Loading plugin %s ...", basename(plugin));
+	/* Ignore leak, we do not support unloading of plugins atm.
+	 * TODO: Add handle to list of loaded plugins, dlclose() on
+	 *       plugin_unregister() */
 	handle = dlopen(plugin, RTLD_LAZY | RTLD_GLOBAL);
 	if (!handle) {
 		_e("Failed loading plugin %s: %s", plugin, dlerror());
@@ -315,7 +276,7 @@ static void check_plugin_depends(plugin_t *plugin)
 	}
 }
 
-int plugin_load_all(char *path)
+int plugin_load_all(uev_ctx_t *ctx, char *path)
 {
 	int fail = 0;
 	DIR *dp = opendir(path);
@@ -338,7 +299,7 @@ int plugin_load_all(char *path)
 	}
 
 	closedir(dp);
-	init_plugins();
+	init_plugins(ctx);
 
 	return fail;
 }

plugin.h

@@ -24,13 +24,13 @@
 #ifndef FINIT_PLUGIN_H_
 #define FINIT_PLUGIN_H_
 
-#include <poll.h>
 #include "queue.h"		/* BSD sys/queue.h API */
 #include "svc.h"
+#include "libuev/uev.h"
 
 #define PLUGIN_DEP_MAX  10
-#define PLUGIN_IO_READ  POLLIN
-#define PLUGIN_IO_WRITE POLLOUT
+#define PLUGIN_IO_READ  UEV_READ
+#define PLUGIN_IO_WRITE UEV_WRITE
 
 #define PLUGIN_INIT(x) static void __attribute__ ((constructor)) x(void)
 #define PLUGIN_EXIT(x) static void __attribute__ ((destructor))  x(void)
@@ -79,6 +79,9 @@ typedef struct plugin {
 	/* BSD sys/queue.h linked list node. */
 	TAILQ_ENTRY(plugin) link;
 
+	/* Event loop handler, used internally by Finit */
+	uev_t watcher;
+
 	/* Plugin name, defaults to basename of plugin path if unset.
 	 * NOTE: Must be same as @cmd for service plugins! */
 	char *name;

plugins/bootmisc.c

@@ -39,25 +39,24 @@ static void setup(void *UNUSED(arg))
 #endif
 
 	_d("Setting up FHS structure in /var ...");
-	mkdir("/var/cache",      0755);
-	mkdir("/var/games",      0755);
-	mkdir("/var/lib",        0755);
-	mkdir("/var/lib/misc",   0755);
-	mkdir("/var/lib/alarm",  0755);
-	mkdir("/var/lock",       0755);
-	mkdir("/var/log",        0755);
-	mkdir("/var/mail",       0755);
-	mkdir("/var/opt",        0755);
-	mkdir("/var/run",        0755);
-	mkdir("/var/spool",      0755);
-	mkdir("/var/spool/cron", 0755);
-	mkdir("/var/tmp",        0755);
-	mkdir("/var/empty",      0755);
+	makedir("/var/cache",      0755);
+	makedir("/var/games",      0755);
+	makedir("/var/lib",        0755);
+	makedir("/var/lib/misc",   0755);
+	makedir("/var/lib/alarm",  0755);
+	makedir("/var/lock",       0755);
+	makedir("/var/log",        0755);
+	makedir("/var/mail",       0755);
+	makedir("/var/opt",        0755);
+	makedir("/var/run",        0755);
+	makedir("/var/spool",      0755);
+	makedir("/var/spool/cron", 0755);
+	makedir("/var/tmp",        0755);
+	makedir("/var/empty",      0755);
 
 	_d("Setting up necessary UTMP files ...");
 	touch("/var/run/utmp");
 	chown("/var/run/utmp", 0, getgroup("utmp"));
-	chmod("/var/run/utmp", 0664);
 
 #ifdef RUNLEVEL
 	memset(&entry, 0, sizeof(struct utmp));
@@ -71,16 +70,16 @@ static void setup(void *UNUSED(arg))
 #ifdef TOUCH_ETC_NETWORK_RUN_IFSTATE
 	touch("/etc/network/run/ifstate");
 #else
-	remove("/etc/network/run/ifstate");
+	erase("/etc/network/run/ifstate");
 #endif
 
 	_d("Setting up misc files ...");
-	mkdir("/var/run/lldpd",  0755); /* Needed by lldpd */
-	mkdir("/var/run/pluto",  0755); /* Needed by Openswan */
-	mkdir("/var/run/quagga", 0755); /* Needed by Quagga */
-	mkdir("/var/log/quagga", 0755); /* Needed by Quagga */
-	mkdir("/var/run/sshd", 01755); /* OpenSSH  */
-	mkfifo("/dev/xconsole", 0640); /* sysklogd */
+	makedir("/var/run/lldpd",  0755); /* Needed by lldpd */
+	makedir("/var/run/pluto",  0755); /* Needed by Openswan */
+	makedir("/var/run/quagga", 0755); /* Needed by Quagga */
+	makedir("/var/log/quagga", 0755); /* Needed by Quagga */
+	makedir("/var/run/sshd", 01755);  /* OpenSSH  */
+	makefifo("/dev/xconsole", 0640);  /* sysklogd */
 	chown("/dev/xconsole", 0, getgroup("tty"));
 }
 

plugins/dbus.c

@@ -29,10 +29,10 @@ static void setup(void *UNUSED(arg))
 {
 #ifdef HAVE_DBUS
 	_d("Starting D-Bus ...");
-	mkdir("/var/run/dbus", 0755);
-	mkdir("/var/lock/subsys/messagebus", 0755);
+	makedir("/var/run/dbus", 0755);
+	makedir("/var/lock/subsys/messagebus", 0755);
 	run("dbus-uuidgen --ensure");
-	remove("/var/run/dbus/pid");
+	erase("/var/run/dbus/pid");
 	run_interactive("dbus-daemon --system", "Starting D-Bus");
 #endif
 }

plugins/initctl.c

@@ -124,7 +124,7 @@ static void parse(void *UNUSED(arg), int fd, int UNUSED(events))
 PLUGIN_INIT(plugin_init)
 {
 	_d("Setting up %s", FINIT_FIFO);
-	mkfifo(FINIT_FIFO, 0600);
+	makefifo(FINIT_FIFO, 0600);
 
 	fifo_open();
 	plugin_register(&plugin);

plugins/urandom.c

@@ -26,16 +26,17 @@
 #include <sys/stat.h>
 
 #include "finit.h"
+#include "libite/lite.h"
 #include "helpers.h"
 #include "plugin.h"
 
 static void setup(void *UNUSED(arg))
 {
 #ifdef RANDOMSEED
-	copyfile(RANDOMSEED, "/dev/urandom", 0);
+	copyfile(RANDOMSEED, "/dev/urandom", 0, 0);
 	unlink(RANDOMSEED);
 	umask(077);
-	copyfile("/dev/urandom", RANDOMSEED, 4096);
+	copyfile("/dev/urandom", RANDOMSEED, 4096, 0);
 	umask(0);
 #endif
 }

plugins/x11-common.c

@@ -36,7 +36,7 @@ static void setup(void *UNUSED(arg))
 #endif
 	char line[LINE_SIZE];
 
-	makepath("/var/run/console");
+	makedir("/var/run/console", 01777);
 	snprintf(line, sizeof(line), "/var/run/console/%s", username);
 	touch(line);
 
@@ -48,8 +48,8 @@ static void setup(void *UNUSED(arg))
 	}
 #endif
 
-	mkdir("/tmp/.X11-unix", 01777);
-	mkdir("/tmp/.ICE-unix", 01777);
+	makedir("/tmp/.X11-unix", 01777);
+	makedir("/tmp/.ICE-unix", 01777);
 }
 
 static plugin_t plugin = {

private.h

@@ -29,11 +29,10 @@
 #include "plugin.h"
 
 void      svc_bootstrap    (void);
-void      svc_monitor      (void);
+void      svc_monitor      (pid_t lost);
 
 void      plugin_run_hooks (hook_point_t no);
-int       plugin_load_all  (char *path);
-void      plugin_monitor   (void);
+int       plugin_load_all  (uev_ctx_t *ctx, char *path);
 
 #endif /* FINIT_PRIVATE_H_ */
 

queue.h

@@ -1,4 +1,4 @@
-/*	$OpenBSD: queue.h,v 1.36 2012/04/11 13:29:14 naddy Exp $	*/
+/*	$OpenBSD: queue.h,v 1.38 2013/07/03 15:05:21 fgsch Exp $	*/
 /*	$NetBSD: queue.h,v 1.11 1996/05/16 05:17:14 mycroft Exp $	*/
 
 /*
@@ -316,6 +316,86 @@ struct {								\
 		(head)->sqh_last = &(elm)->field.sqe_next;		\
 } while (0)
 
+/*
+ * XOR Simple queue definitions.
+ */
+#define XSIMPLEQ_HEAD(name, type)					\
+struct name {								\
+	struct type *sqx_first;	/* first element */			\
+	struct type **sqx_last;	/* addr of last next element */		\
+	unsigned long sqx_cookie;					\
+}
+
+#define XSIMPLEQ_ENTRY(type)						\
+struct {								\
+	struct type *sqx_next;	/* next element */			\
+}
+
+/*
+ * XOR Simple queue access methods.
+ */
+#define XSIMPLEQ_XOR(head, ptr)	    ((__typeof(ptr))((head)->sqx_cookie ^ \
+					(unsigned long)(ptr)))
+#define	XSIMPLEQ_FIRST(head)	    XSIMPLEQ_XOR(head, ((head)->sqx_first))
+#define	XSIMPLEQ_END(head)	    NULL
+#define	XSIMPLEQ_EMPTY(head)	    (XSIMPLEQ_FIRST(head) == XSIMPLEQ_END(head))
+#define	XSIMPLEQ_NEXT(head, elm, field)    XSIMPLEQ_XOR(head, ((elm)->field.sqx_next))
+
+
+#define XSIMPLEQ_FOREACH(var, head, field)				\
+	for ((var) = XSIMPLEQ_FIRST(head);				\
+	    (var) != XSIMPLEQ_END(head);				\
+	    (var) = XSIMPLEQ_NEXT(head, var, field))
+
+#define	XSIMPLEQ_FOREACH_SAFE(var, head, field, tvar)			\
+	for ((var) = XSIMPLEQ_FIRST(head);				\
+	    (var) && ((tvar) = XSIMPLEQ_NEXT(head, var, field), 1);	\
+	    (var) = (tvar))
+
+/*
+ * XOR Simple queue functions.
+ */
+#define	XSIMPLEQ_INIT(head) do {					\
+	arc4random_buf(&(head)->sqx_cookie, sizeof((head)->sqx_cookie)); \
+	(head)->sqx_first = XSIMPLEQ_XOR(head, NULL);			\
+	(head)->sqx_last = XSIMPLEQ_XOR(head, &(head)->sqx_first);	\
+} while (0)
+
+#define XSIMPLEQ_INSERT_HEAD(head, elm, field) do {			\
+	if (((elm)->field.sqx_next = (head)->sqx_first) ==		\
+	    XSIMPLEQ_XOR(head, NULL))					\
+		(head)->sqx_last = XSIMPLEQ_XOR(head, &(elm)->field.sqx_next); \
+	(head)->sqx_first = XSIMPLEQ_XOR(head, (elm));			\
+} while (0)
+
+#define XSIMPLEQ_INSERT_TAIL(head, elm, field) do {			\
+	(elm)->field.sqx_next = XSIMPLEQ_XOR(head, NULL);		\
+	*(XSIMPLEQ_XOR(head, (head)->sqx_last)) = XSIMPLEQ_XOR(head, (elm)); \
+	(head)->sqx_last = XSIMPLEQ_XOR(head, &(elm)->field.sqx_next);	\
+} while (0)
+
+#define XSIMPLEQ_INSERT_AFTER(head, listelm, elm, field) do {		\
+	if (((elm)->field.sqx_next = (listelm)->field.sqx_next) ==	\
+	    XSIMPLEQ_XOR(head, NULL))					\
+		(head)->sqx_last = XSIMPLEQ_XOR(head, &(elm)->field.sqx_next); \
+	(listelm)->field.sqx_next = XSIMPLEQ_XOR(head, (elm));		\
+} while (0)
+
+#define XSIMPLEQ_REMOVE_HEAD(head, field) do {				\
+	if (((head)->sqx_first = XSIMPLEQ_XOR(head,			\
+	    (head)->sqx_first)->field.sqx_next) == XSIMPLEQ_XOR(head, NULL)) \
+		(head)->sqx_last = XSIMPLEQ_XOR(head, &(head)->sqx_first); \
+} while (0)
+
+#define XSIMPLEQ_REMOVE_AFTER(head, elm, field) do {			\
+	if (((elm)->field.sqx_next = XSIMPLEQ_XOR(head,			\
+	    (elm)->field.sqx_next)->field.sqx_next)			\
+	    == XSIMPLEQ_XOR(head, NULL))				\
+		(head)->sqx_last = 					\
+		    XSIMPLEQ_XOR(head, &(elm)->field.sqx_next);		\
+} while (0)
+
+		    
 /*
  * Tail queue definitions.
  */
@@ -553,12 +633,12 @@ struct {								\
 #define CIRCLEQ_REPLACE(head, elm, elm2, field) do {			\
 	if (((elm2)->field.cqe_next = (elm)->field.cqe_next) ==		\
 	    CIRCLEQ_END(head))						\
-		(head).cqh_last = (elm2);				\
+		(head)->cqh_last = (elm2);				\
 	else								\
 		(elm2)->field.cqe_next->field.cqe_prev = (elm2);	\
 	if (((elm2)->field.cqe_prev = (elm)->field.cqe_prev) ==		\
 	    CIRCLEQ_END(head))						\
-		(head).cqh_first = (elm2);				\
+		(head)->cqh_first = (elm2);				\
 	else								\
 		(elm2)->field.cqe_prev->field.cqe_next = (elm2);	\
 	_Q_INVALIDATE((elm)->field.cqe_prev);				\

sig.c

@@ -47,9 +47,13 @@
 #include "private.h"
 #include "sig.h"
 
-static int stopped = 0;
+static int   stopped = 0;
+static uev_t sigint_watcher, sigpwr_watcher;
+static uev_t sigchld_watcher;
+static uev_t sigstop_watcher, sigtstp_watcher, sigcont_watcher;
 
-void do_shutdown (int sig)
+
+void do_shutdown(int sig)
 {
 	touch(SYNC_SHUTDOWN);
 
@@ -84,40 +88,37 @@ void do_shutdown (int sig)
 }
 
 /*
- * Shut down on INT USR1 USR2
+ * Shut down on INT PWR
  */
-static void shutdown_handler(int sig, siginfo_t *info, void *UNUSED(ctx))
+static void sigint_cb(uev_ctx_t *UNUSED(ctx), uev_t *w, void *UNUSED(arg), int UNUSED(events))
 {
-	_d("Rebooting on signal %d from %s (PID %d)",
-	   sig, pid_get_name(info->si_pid, NULL, 0), info->si_pid);
-
-	do_shutdown(sig);
+	do_shutdown(w->signo);
 }
 
 /*
  * SIGCHLD: one of our children has died
  */
-static void chld_handler(int UNUSED(sig), siginfo_t *UNUSED(info), void *UNUSED(ctx))
+static void sigchld_cb(uev_ctx_t *UNUSED(ctx), uev_t *UNUSED(w), void *UNUSED(arg), int UNUSED(events))
 {
-	/* Do nothing, the svc_monitor() is the designated child reaper. */
+	svc_monitor(waitpid(-1, NULL, WNOHANG));
 }
 
 /*
- * SIGSTOP: Paused by user or netflash
+ * SIGSTOP/SIGTSTP: Paused by user or netflash
  */
-static void sigstop_handler(int sig, siginfo_t *info, void *UNUSED(ctx))
+static void sigstop_cb(uev_ctx_t *UNUSED(ctx), uev_t *UNUSED(w), void *UNUSED(arg), int UNUSED(events))
 {
-	_d("Received SIGSTOP(%d) from %s (PID %d)",
-	   sig, pid_get_name(info->si_pid, NULL, 0), info->si_pid);
 	touch(SYNC_STOPPED);
 	stopped++;
 }
-static void sigcont_handler(int sig, siginfo_t *info, void *UNUSED(ctx))
+
+/*
+ * SIGCONT: Restart service monitor
+ */
+static void sigcont_cb(uev_ctx_t *UNUSED(ctx), uev_t *UNUSED(w), void *UNUSED(arg), int UNUSED(events))
 {
-	_d("Received SIGCONT(%d) from %s (PID %d)",
-	   sig, pid_get_name(info->si_pid, NULL, 0), info->si_pid);
 	stopped = 0;
-	remove(SYNC_STOPPED);
+	erase(SYNC_STOPPED);
 }
 
 /*
@@ -131,6 +132,11 @@ int sig_stopped(void)
 /*
  * Inital signal setup - ignore everything but SIGCHLD until we're capable of responding
  */
+static void chld_handler(int UNUSED(sig), siginfo_t *UNUSED(info), void *UNUSED(ctx))
+{
+	/* NOP */
+}
+
 void sig_init(void)
 {
 	int i;
@@ -142,26 +148,49 @@ void sig_init(void)
 	SETSIG(sa, SIGCHLD, chld_handler, SA_RESTART);
 }
 
+/*
+ * Unblock all signals blocked by finit when starting children
+ */
+void sig_unblock(void)
+{
+	int i;
+	sigset_t nmask;
+	struct sigaction sa;
+
+	sigemptyset(&nmask);
+	sigaddset(&nmask, SIGCHLD);
+	sigaddset(&nmask, SIGINT);
+	sigaddset(&nmask, SIGPWR);
+	sigaddset(&nmask, SIGSTOP);
+	sigaddset(&nmask, SIGTSTP);
+	sigaddset(&nmask, SIGCONT);
+	sigprocmask(SIG_UNBLOCK, &nmask, NULL);
+
+	/* Reset signal handlers that were set by the parent process */
+	for (i = 1; i < NSIG; i++)
+		DFLSIG(sa, i, 0);
+}
+
 /*
  * Setup limited set of SysV compatible signals to respond to
  */
-void sig_setup(void)
+void sig_setup(uev_ctx_t *ctx)
 {
 	struct sigaction sa;
 
 	_d("Setup signals");
 
 	/* Cleanup any stale finit control files */
-	remove(SYNC_SHUTDOWN);
-	remove(SYNC_STOPPED);
+	erase(SYNC_SHUTDOWN);
+	erase(SYNC_STOPPED);
 
 	/* Standard SysV init calls ctrl-alt-delete handler */
-	SETSIG(sa, SIGINT,  shutdown_handler, 0);
-	SETSIG(sa, SIGPWR,  shutdown_handler, 0);
+	uev_signal_init(ctx, &sigint_watcher, sigint_cb, NULL, SIGINT);
+	uev_signal_init(ctx, &sigpwr_watcher, sigint_cb, NULL, SIGPWR);
 
 	/* Ignore SIGUSR1/2 for now, only BusyBox init implements them as reboot+halt. */
-//	  SETSIG2(sa, SIGUSR1, reopen_initctl, 0);
-//	  SETSIG2(sa, SIGUSR2, pwrdwn_handler, 0);
+//	uev_signal_init(&ctx, &sigusr1_watcher, reopen_initctl_cb, NULL, SIGUSR1);
+//	uev_signal_init(&ctx, &sigusr2_watcher, pwrdwn_cb, NULL, SIGUSR2);
 
 	/* Init must ignore SIGTERM. May otherwise get false SIGTERM in forked children! */
 	IGNSIG(sa, SIGTERM, 0);
@@ -172,10 +201,13 @@ void sig_setup(void)
 	/* We don't have any /etc/inittab yet, reread finit.conf? */
 	IGNSIG(sa, SIGHUP, 0);
 
+	/* After initial bootstrap of Finit we call the service monitor to reap children */
+	uev_signal_init(ctx, &sigchld_watcher, sigchld_cb, NULL, SIGCHLD);
+
 	/* Stopping init is a bit tricky. */
-	SETSIG(sa, SIGSTOP, sigstop_handler, 0);
-	SETSIG(sa, SIGTSTP, sigstop_handler, 0);
-	SETSIG(sa, SIGCONT, sigcont_handler, 0);
+	uev_signal_init(ctx, &sigstop_watcher, sigstop_cb, NULL, SIGSTOP);
+	uev_signal_init(ctx, &sigtstp_watcher, sigstop_cb, NULL, SIGTSTP);
+	uev_signal_init(ctx, &sigcont_watcher, sigcont_cb, NULL, SIGCONT);
 
 	/* Disable CTRL-ALT-DELETE from kernel, we handle shutdown gracefully with SIGINT, above */
 	reboot(RB_DISABLE_CAD);

sig.h

@@ -26,6 +26,7 @@
 #define FINIT_SIG_H_
 
 #include <signal.h>
+#include "libuev/uev.h"
 
 #define SYNC_SHUTDOWN   "/var/lock/finit.shutdown"
 #define SYNC_STOPPED    "/var/lock/finit.stopped"
@@ -57,7 +58,8 @@
 void do_shutdown    (int sig);
 int  sig_stopped    (void);
 void sig_init       (void);
-void sig_setup      (void);
+void sig_unblock    (void);
+void sig_setup      (uev_ctx_t *ctx);
 
 #endif /* FINIT_SIG_H_ */
 

svc.c

@@ -143,16 +143,18 @@ void svc_bootstrap(void)
 	}
 }
 
+static int encode(int lvl)
+{
+	if (!lvl)
+		return 0;
+
+	return lvl + '0';
+}
+
 static void utmp_save(int pre, int now)
 {
    struct utmp utent;
 
-   int encode(int lvl)
-   {
-	   if (!lvl) return 0;
-	   return lvl + '0';
-   }
-
    utent.ut_type  = RUN_LVL;
    utent.ut_pid   = (encode(pre) << 8) | (encode(now) & 0xFF);
    strlcpy(utent.ut_user, "runlevel", sizeof(utent.ut_user));
@@ -209,7 +211,7 @@ void svc_runlevel(int newlevel)
 	if (runlevel == 1)
 		touch("/etc/nologin");	/* Disable login in single-user mode */
 	else
-		remove("/etc/nologin");
+		erase("/etc/nologin");
 
 	if (0 != prevlevel)
 		tty_runlevel(runlevel);
@@ -360,9 +362,8 @@ static void restart_any_lost_procs(void)
 	}
 }
 
-void svc_monitor(void)
+void svc_monitor(pid_t lost)
 {
-	pid_t lost;
 	svc_t *svc;
 
 	if (was_stopped && !is_norespawn()) {
@@ -371,10 +372,6 @@ void svc_monitor(void)
 		return;
 	}
 
-	lost = waitpid(-1, NULL, WNOHANG);
-	if (lost < 1)
-		return;
-
 	if (fexist(SYNC_SHUTDOWN) || lost <= 1)
 		return;
 
@@ -456,7 +453,7 @@ int svc_start(svc_t *svc)
 	sigaddset(&nmask, SIGCHLD);
 	sigprocmask(SIG_BLOCK, &nmask, &omask);
 
-	pid = fork();
+	pid = vfork();
 	sigprocmask(SIG_SETMASK, &omask, NULL);
 	if (pid == 0) {
 		int i = 0;
@@ -477,7 +474,7 @@ int svc_start(svc_t *svc)
 			setuid(uid);
 
 		/* Serve copy of args to process in case it modifies them. */
-		for (i = 0; i < MAX_NUM_SVC_ARGS && svc->args[i][0] != 0; i++)
+		for (i = 0; i < (MAX_NUM_SVC_ARGS - 1) && svc->args[i][0] != 0; i++)
 			args[i] = svc->args[i];
 		args[i] = NULL;
 
@@ -487,8 +484,9 @@ int svc_start(svc_t *svc)
 
 			fd = open(CONSOLE, O_WRONLY | O_APPEND);
 			if (-1 != fd) {
-				dup2(STDOUT_FILENO, fd);
-				dup2(STDERR_FILENO, fd);
+				dup2(fd, STDOUT_FILENO);
+				dup2(fd, STDERR_FILENO);
+				close(fd);
 			}
 
 			for (i = 0; i < MAX_NUM_SVC_ARGS && args[i]; i++) {

tty.c

@@ -144,7 +144,7 @@ void tty_start(finit_tty_t *tty)
 #elif defined(GETTY_BUSYBOX)
 		snprintf(line, sizeof(line), "%s %d %s %s", GETTY, tty->baud, tty->name, tty->term ?: "");
 #else
-		strlcpy(line, FALLBACK_CONSOLE, sizeof(line));
+		strlcpy(line, FALLBACK_SHELL, sizeof(line));
 #endif
 	} else {
 		strlcpy(line, tty->name, sizeof(line));
@@ -179,7 +179,7 @@ int tty_enabled(finit_tty_t *tty, int runlevel)
 
 	if (!ISSET(tty->runlevels, runlevel))
 		return 0;
-	else if (fexist(tty->name))
+	if (fexist(tty->name))
 		return 1;
 
 	return 0;