Update ChangeLog and bump version for 4.10-rc2

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
plugins: rtc: follow-up to bc8118d, stop timer at shutdown
2026-10-12 10:12:32 +00:00 · 2025-02-28 12:11:06 +01:00 · 2025-02-28 11:17:01 +01:00 · 2025-02-25 08:37:27 +01:00 · 2025-02-23 12:35:48 +01:00 · 2025-02-23 12:34:02 +01:00
7 changed files with 20 additions and 12 deletions
@@ -4,6 +4,7 @@ on:
  push:
    branches:
      - 'dev'
+  workflow_dispatch:

 env:
  PROJECT_NAME: finit
@@ -4,7 +4,7 @@ Change Log
 All relevant changes are documented in this file.


-[4.10][] - 2025-02-23
+[4.10][] - 2025-02-28
 ---------------------

 ### Changes
@@ -17,6 +17,7 @@ All relevant changes are documented in this file.
 - Fix #427: using an external getty with custom login program cause
   Finit to use login program as the getty command
 - Fix #428: allow `sysctl` path to be set at build time
+ - Fix #429: regression in v4.9 causing Finit to segfault at shutdown
 - Fix possible memory leak when sourcing a service `env:file`
 - Finit now waits until all `post:scripts` have run before returning
   OK to `initctl <reload|runlevel>`.  This also applies to the new
@@ -1,4 +1,4 @@
-AC_INIT([Finit], [4.10-rc1], [https://github.com/troglobit/finit/issues],
+AC_INIT([Finit], [4.10-rc2], [https://github.com/troglobit/finit/issues],
 	[finit], [https://troglobit.com/projects/finit/])
 AC_CONFIG_AUX_DIR(aux)
 AM_INIT_AUTOMAKE([1.11 foreign dist-xz subdir-objects])
@@ -338,6 +338,7 @@ PLUGIN_INIT(plugin_init)

 PLUGIN_EXIT(plugin_exit)
 {
+	uev_timer_stop(&rtc_timer);
 	plugin_unregister(&plugin);
 }

@@ -1675,6 +1675,7 @@ int service_register(int type, char *cfg, struct rlimit rlimit[], char *file)
 		if (tty_parse_args(&tty, cmd, &args))
 			return errno;

+		/* NOTE: this may result in dev == NULL! */
 		if (tty_isatcon(tty.dev))
 			dev = tty_atcon();
 		else
@@ -1707,17 +1708,19 @@ int service_register(int type, char *cfg, struct rlimit rlimit[], char *file)
 		respawn = 1;

 		/* Create name:id tuple for identity, e.g., tty:S0 */
-		ptr = strrchr(dev, '/');
-		if (ptr)
-			ptr++;
-		else
-			ptr = dev;
-		if (!strncmp(ptr, "tty", 3))
-			ptr += 3;
+		if (dev) {
+			ptr = strrchr(dev, '/');
+			if (ptr)
+				ptr++;
+			else
+				ptr = dev;
+			if (!strncmp(ptr, "tty", 3))
+				ptr += 3;

-		name = "tty";
-		if (!id || id[0] == 0)
-			id = ptr;
+			name = "tty";
+			if (!id || id[0] == 0)
+				id = ptr;
+		}

 		svc = svc_find_by_tty(dev);
 	} else
@@ -232,6 +232,8 @@ void do_iterate_proc(int (*cb)(int, void *), void *data)
 					dbg("Skipping %s ...", file);
 				else if (file[0] == '@')
 					dbg("Skipping %s ...", &file[1]);
+				else if (strstr(file, "initctl"))
+					dbg("Skipping %s ...", file);
 				else
 					if (cb(pid, data)) {
 						dbg("PID %d is still alive (%s)", pid, file);
Author	SHA1	Message	Date
Joachim Wiberg	c371c10455	Update ChangeLog and bump version for 4.10-rc2 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>	2025-02-28 12:11:06 +01:00
Joachim Wiberg	a23e152f6b	plugins: rtc: follow-up to `bc8118d`, stop timer at shutdown Introduced to work-around systems with broken RTCs, it also introduced a dormant bug in Finit, triggered at shutdown on some systems. The call to dlclose() removed the memory to the rtc_timer which libuev later then referenced. Fixes #429 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>	2025-02-28 11:17:01 +01:00
Joachim Wiberg	9210f2851e	Skip killing initctl on shutdown/reboot Initiating a shutdown/reboot from `initctl` should not cause `initctl` to be killed in do_shutdown(). Signed-off-by: Joachim Wiberg <troglobit@gmail.com>	2025-02-25 08:37:27 +01:00
Joachim Wiberg	617609cbc5	.github: allow running coverity scan on workflow dispatch [skip ci] Signed-off-by: Joachim Wiberg <troglobit@gmail.com>	2025-02-23 12:35:48 +01:00
Joachim Wiberg	b022916758	doc: update svc_t state machine, drop transparent background The transparent png is completely illegible in dark mode. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>	2025-02-23 12:34:02 +01:00
Joachim Wiberg	9a357b7aab	Fix possible NULL pointer dereference When a user sets up a TTY without a device, triggering the tty->notty code path, the tty->dev will be NULL and tty_parse_args() still return OK result. Found by Coverity Scan Signed-off-by: Joachim Wiberg <troglobit@gmail.com>	2025-02-23 10:30:16 +01:00