In (very) modern versions of binutils, for instance v2.25.1 in Ubuntu
15.10, complain about VERY common `crus` argument. This patch attempts
to silence this noise:
$ make -j5
CC uev.o
CC io.o
CC timer.o
CC signal.o
ARCHIVE libuev.a
LINK libuev.so.1
ar: `u' modifier ignored since `D' is the default (see `U')
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Got very odd results on Debian Jessie when having the uev_private_t last
in uev_t. Turns out that when uev.c set "w->active = 0;" the w->fd data
member was written to instead.
Placing the private data first in uev_t is better practise, generally a
good thing for linked lists built on the BSD sys/queue.h API, looks a
lot better, but foremost works.
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
It is non-trivial to set a separate environment variable (STATIC=1) when
descending into the libuEv subdirectory from an autoconf/automake based
project.
It is better to instead simplify the build process and always build both
.a and .so files.
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
While comparing the library layout with libite, I noticed how the
formatting of the license paragraphs in all source files had been
garbled. This patch restores the orginal line breaks.
Note: Only whitespace changes, no change in licensing terms!
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
There really does not exist a good reason for us sending a `uev_ctx_t *`
pointer as the first argument to event callbacks. If the callback needs
to reference the context, it can find the ctx pointer in the `uev_t *w`.
This patch removes the first argument from all callbacks and also fixes
a slight bug in that the event loop never returned the actual event that
triggered the callback!
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
There currenty is no *simple* way of preventing Coverity from being run
twice, so we just remove the clang build in the meantime :-/
See: travis-ci/travis-ci#1975
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
- Make sure to listen for EPOLLRDHUP in watchers so users can be
notified when a peer closes a connection.
- Handle EPOLLHUP and EPOLLERR gracefully. Even handle spurious
EPOLLHUP by means of an error counter. If we receive too many errors
we now restart the epoll fd and re-add all watchers.
- Return error from `epoll_ctl()` in `uev_watcher_stop()`
- Ignore any error from `uev_watcher_stop()` in `uev_watcher_set()`
- Move LIST_REMOVE() et al from io.c to core uev.c, should be
done for timer and signal callbacks as well, of course.
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Use OpenBSD version of queue.h since the C-library may not have it (at
all), or may come with an older (buggy) version.
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
We don't want to run out of scan tokens for every README update. This
also means the introduction of a new workflow. All new development must
be staged to the dev branch before being merged to master.
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Update copyright years of all sources.
Reflow/reformat paragraphs in MIT license to match Finit,
i.e., no content changes only whitespace/linebreak changes.
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
- Rename all _create() functions --> _init()
- Rename all _delete() functions --> _stop()
- Watchers are automatically started, except
- Timer watchers are automatically started by uev_run()
- Allow I/O watchers to watch either EV_READ/EV_WRITE or both events
- Extend callbacks with a received events field
- Remove calloc()/free(), let user handle this
- Make event has-a context when initializing it => simplifies API
- Internal uev_watcher_*() API mostly handles epoll stop/start
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Split libuev.c into one file per watcher type, mostly to give a better
overview and ease of maintenance, but also to help the linker.
Unfortunately this steals a few bytes when linking a full blown app, but
for apps that, e.g., only need I/O watchers and no timers the resulting
binary will be smaller. This applies to static binaries that are more
common in embedded systems.
$ size libuev.a libuev.so.1
text data bss dec hex filename
999 0 0 999 3e7 main.o (ex libuev.a)
90 0 0 90 5a io.o (ex libuev.a)
490 0 0 490 1ea timer.o (ex libuev.a)
4380 696 8 5084 13dc libuev.so.1
Also, move uev.h back to top from include/libuev/uev.h since a separate
namespace is not needed after the removal of the OpenBSD queue.h copy.
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
- Cleanup code
- Further polish on total size using black magic
- Remove OpenBSD queue.h, code simplied so much now it's not needed anymore.
Instead we can rely on the standard GNU/Linux sys/queue.h (old BSD copy)
$ size libuev.a libuev.so.1
text data bss dec hex filename
1520 0 0 1520 5f0 libuev.o (ex libuev.a)
4194 680 8 4882 1312 libuev.so.1
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
- Remove double book keeping, the kernel does all the heavy lifting now
- Trim the amount of #includes
- Use LIST_ instead of TAILQ_ now that we no longer handle timers ourselves
Original LibUEvent
$ size libuevent.a libuevent.so.1
text data bss dec hex filename
2610 0 8 2618 a3a libuevent.o (ex libuevent.a)
5266 648 16 5930 172a libuevent.so.1
Refactored libuev:
$ size libuev.a libuev.so.1
text data bss dec hex filename
1557 0 0 1557 615 libuev.o (ex libuev.a)
4186 672 8 4866 1302 libuev.so.1
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Joachim Nilsson