Commit Graph
122 Commits
Author SHA1 Message Date
Jean Delvare 78f496ca62 libsensors: New method to free the memory allocated for the internal
representation of chip names.
sensord, sensors: Fix a memory leak when one or more chip names are
provided on the command line.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5740 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-06-20 10:04:52 +00:00
Jean Delvare ef2f2c04ce Use the "daemon" logging facility instead of "local4" by default.
Local facilities are meant for local uses, no daemon should use it by
default.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5737 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-06-11 17:39:48 +00:00
Jean Delvare 8eeb9081a8 Optimize CGI generation code a bit.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5736 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-06-09 12:44:44 +00:00
Jean Delvare a5bb03f300 Disable unit scaling for fan speeds. We want fan speed to be reported as
3000 RPM, not 3.0 kRPM.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5735 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-06-09 12:22:11 +00:00
Jean Delvare 098ae6d2e5 Don't use the system log when generating a CGI script. This is is
normally done by a human on a console, rather than in the background,
so the system log isn't where people would look for error messages.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5734 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-06-09 12:19:53 +00:00
Andre Prendel cae8b2a1e7 sensord: Fix build error.
This is caused by a missing file (prog/sensord/args.h) in commit:

r5719 sensord: Introduce struct sensord_args.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5732 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-06-09 08:02:49 +00:00
Andre Prendel 73911c4c93 sensord: Refactoring of the rrdInit() function.
* Fix deep indentation levels
* Return with unique error code (-1)
* Rename buffer for struct stat from tmp to sb.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5724 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-05-13 16:13:41 +00:00
Andre Prendel 13dc7c0232 Replace the deprecated signal() function by sigaction().
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5723 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-05-13 16:11:57 +00:00
Andre Prendel f5aaeec448 sensord: This patch does some refactoring of the loadConfig()
function.

* Simplifying the conditions makes code flow clearer and eliminates
long lines (> 80 chars).
* Removed useless stat() call.
* Return -1 in error case, instead of several positive values (never defined).


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5722 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-05-13 16:09:06 +00:00
Andre Prendel b5375e4344 sensord: Did some refactoring in parseChips(). This fixes some deep indentation
levels.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5721 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-05-13 16:07:50 +00:00
Andre Prendel d71ed51702 sensord: Removed useless breaks after some exit() calls.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5720 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-05-13 16:06:17 +00:00
Andre Prendel 49344ef205 sensord: Introduce struct sensord_args.
This structure encapsulate all the variables holding the commandline
arguments. So we get rid of plenty of extern variables. This reduces
namespace collisions and unifies access.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5719 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-05-13 16:04:51 +00:00
Andre Prendel b42461426d sensord: Remove the hidden commandline interface.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5718 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-05-13 16:03:23 +00:00
Andre Prendel 3a002f7487 sensord: Remove leading whitespaces in empty lines.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5679 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-03-10 10:37:41 +00:00
Andre Prendel e065e827e9 Convert coding style in prog/sensord/ from gnu to kernel style.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5678 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-03-09 15:32:03 +00:00
Jean Delvare 93aa7f3222 Don't bail out on transient errors (#2330).
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5580 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-01-08 11:01:41 +00:00
Jean Delvare 05db7e0c10 Accept negative temperatures in RRD database.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5473 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-11-30 13:18:35 +00:00
Jean Delvare aa47fb99e2 Fix support of multiple chip names on the command line. It got broken
accidentally during the conversion to the new libsensors API in version
3.0.0. This closes ticket #2321.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5252 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-05-12 11:51:18 +00:00
Jean Delvare f2e518511d Patch from Aurelien Jarno:
I have just noticed that the FSF address is the old one in all files
except COPYING. Please find a patch below to fix that.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5163 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-03-26 13:37:12 +00:00
Jean Delvare b029b8f861 sensord: Drop workaround needed by old versions of rrdtool. The bug
(missing getopt variables initialization) was fixed in rrdtool version
1.2.1, 2.5 years ago.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5072 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-12-11 22:56:47 +00:00
Jean Delvare 9dbde1cc06 Drop unneeded include.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5071 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-12-11 22:00:49 +00:00
Jean Delvare e257a45fed sensord: Use the same colors for daily and weekly charts.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5070 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-12-11 21:48:34 +00:00
Jean Delvare 4f8196934c sensord: Fix rrd support (#2276).
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5069 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-12-11 13:14:39 +00:00
Jean Delvare 35a5a7dbce Use /etc/sensors3.conf as the default configuration file. If it can't
be found, fallback to /etc/sensors.conf. This allows for an old
libsensors and a new libsensors to be installed in parallel, and each
one has its own configuration file.

One important change here is that the default configuration file will
be installed as /etc/sensors3.conf by "make install".


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4990 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-10-25 09:59:05 +00:00
Jean Delvare 6d5292cce4 "sensord" no longer needs a default configuration file name. If no
file name is provided on the command line, use the libsensors default.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4987 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-10-25 09:50:17 +00:00
Jean Delvare 3d9acfa6f9 sensord: Reload config on SIGHUP rather than automatically.
Reloading the configuration on SIGHUP is common for daemons. Reloading
automatically is less efficient and can be confusing or even racy.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4969 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-10-20 14:05:35 +00:00
Jean Delvare ff46494457 sensord manual page update.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4919 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-10-07 07:32:21 +00:00
Jean Delvare 3a87a433fd Drop the configuration file search path mechanism from sensord. It's
confusing and useless. We dropped it from sensors years ago.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4918 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-10-07 07:23:32 +00:00
Jean Delvare cb5a94578d Chip-specific code is gone.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4914 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-10-01 17:05:34 +00:00
Jean Delvare 43e4f551b7 Log the error code on failure, to make it easier to investigate
problems.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4888 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-26 17:15:13 +00:00
Jean Delvare 4b6f9ee727 Better error message if configuration file can't be loaded.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4853 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-23 13:48:52 +00:00
Jean Delvare c390c9e29f Hide warnings about unused parameters.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4849 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-23 12:47:27 +00:00
Jean Delvare e01466d993 New public library function: sensors_get_subfeature(). Applications can
use it to retrieve a specific subfeature by type. While it is slighly
less efficient than looping over sensors_get_all_subfeatures(), it
often makes the application code much more elegant.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4846 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-23 12:30:28 +00:00
Jean Delvare da7b4e48da Introduce a separate type for main features. Make subfeatures map to
the real main feature rather than the first subfeature.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4838 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-23 12:16:50 +00:00
Jean Delvare 65f1d1f1cd Rename subfeature types from *_FEATURE_* to *_SUBFEATURE_*, to better
reflect what they represent.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4837 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-23 12:12:19 +00:00
Jean Delvare 96c914bfda Define a separate structure to represent main features. This allows
for faster main features lookup. One side effect of this change is
that subfeatures can no longer have labels nor be ignored. I do not
think that this is a problem in practice, and actually this makes a
lot of sense.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4834 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-23 12:05:16 +00:00
Jean Delvare bfe337fe76 Store current temperature, voltage and fan values together with
the rest of the subfeatures. This makes the code more simple, and
prepares for current values to be subfeatures like any others (i.e.
they can be missing.)


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4833 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-23 12:02:59 +00:00
Jean Delvare 79086fb7b8 Rename struct sensors_feature_data to sensors_subfeature. This is a
first step towards a clean separation between main features and
subfeatures.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4832 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-23 12:02:22 +00:00
Jean Delvare eba601a964 Split sensors_get_all_features() into two distinct functions, one to
get the list of all main features, and one to get the list of all the
subfeatures of a given main feature. This is a more logical interface for
applications to use. The current implementation is admittedly less than
optimal, because the storage structures weren't meant for it, but this
issue can (and will) be addressed later.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4831 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-23 12:00:59 +00:00
Jean Delvare 5bd020ad92 Scan chip features only once at initialization time, rather than on
each update. The chip list and chip features do not change until
sensors_cleanup() is called, so there's no point in doing the
same work over and over again.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4828 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-21 12:15:18 +00:00
Jean Delvare 49649fcf05 Restore support for beeps.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4827 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-20 21:24:12 +00:00
Jean Delvare 36ded1b5fc Restore support for alarms.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4825 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-20 21:22:42 +00:00
Jean Delvare 071e4a8008 Rename a few variables to something that makes more sense.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4824 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-20 16:22:13 +00:00
Jean Delvare afddd25552 Drop support for printing unknown chips: all chips are known now.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4819 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-19 15:16:14 +00:00
Jean Delvare 2837b67281 Delete unused formatting functions.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4818 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-19 15:12:58 +00:00
Jean Delvare 2e773670b8 Add generic chip support to sensord, much like sensors has.
Alarm and beep mask support is still missing.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4817 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-19 15:11:34 +00:00
Jean Delvare d3b00b0a86 Fix memory leaks in command line parsing.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4816 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-19 15:10:06 +00:00
Jean Delvare 347b0d1965 Fix a memory leak when daemonizing.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4815 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-19 14:25:19 +00:00
Jean Delvare 0ec61f1bc7 Warning fixes.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4807 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-18 20:53:42 +00:00
Jean Delvare 73cdb48635 Fix compilation breakage.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4806 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-18 20:46:06 +00:00