patch from Ken Healy <k.healy@student.ucc.ie>
This patch experimentally enables SiS 655 support by the i2c-sis645 driver.
It simply modifies the driver to also accept the SiS 655 as a valid host
bridge.
Partially tested on a Gigabyte GA-SINXP1394 (SiS655/963), no problems so far.
Driver successfully enables the SMBus controller, i2cdetect finds the usual
devices, and i2cdump successfully reads the DIMM SPD eeprom's.
The patch is against the lm_sensors-2.8.5 release.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@2415 7894878c-1315-0410-8ee3-d5d059ff63e0
This patch fixes a "Trying to release non-existent resource" error that
occurs during rmmod when the device isn't actually present. It includes
some other cleanups too: error paths, whitespace, magic numbers, __devinit.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@2248 7894878c-1315-0410-8ee3-d5d059ff63e0
Date: Thu, 18 Dec 2003 22:42:36 +0100
From: Haakon Riiser <haakon.riiser@fys.uio.no>
To: sensors@Stimpy.netroedge.com
Subject: lm_sensors 2.8.2 / DESTDIR / root
The reason for this email is that I always try to avoid running
Makefiles as root, even during 'make install'. Therefore, I
always use the DESTDIR feature, when it's available. Until today,
I always built i2c and lm_sensors by doing
$ make
$ make -i install DESTDIR=/foo
$ cd /foo && su root && fix permissions/ownership && install
The -i flag to make install is a kludge to avoid having to be root
while installing to the DESTDIR, and it's only required because
the files are installed with "-o root -g root". Using the -i
flag is of course not a good idea, since more fatal errors can
easily fly by undetected.
Today, I upgraded to Linux 2.6.0, and tried a similar install
procedure for lm_sensors, except that the make target is now "user"
and the install target is "user_install". I now noticed that the
DESTDIR variable is not used everywhere in "user_install", so I
couldn't use the -i kludge anymore. Instead, I wrote a patch that
removes the "-o root -g root" arguments to install everywhere, and
I also tried to add DESTDIR to all files/directories installed.
(The patch only applies to lm_sensors, not i2c, since only
lm_sensors is required in Linux 2.6.0.)
There's really no reason to say -o root -g root anyway, since if you
do install directly with make install, you have to be logged in as
root, and then the files will get the right ownership by default.
Much of the point of installing to a temporary DESTDIR is that you
don't have to be root, and that you can prepare the installation
by hand. Fixing the ownership is trivial:
chown -R root.root $DESTDIR
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@2189 7894878c-1315-0410-8ee3-d5d059ff63e0
(mmh) o remove devinitdata marking from i2c-nforce2.c as it's wrong
(mmh) o minor cleanups to the i2c-nforce2 driver
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@1938 7894878c-1315-0410-8ee3-d5d059ff63e0
SMBus pci device only - instead of also claiming the south bridge.
Although no problems had been reported with the previous detection
strategy, this change avoids the class of problems mentioned here:
http://archives.andrew.net.au/lm-sensors/msg03193.html
As a side benefit, it now looks much more like its sibling in 2.5.7x.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@1893 7894878c-1315-0410-8ee3-d5d059ff63e0
in cleanup. Dummy adapters must return 0, otherwise they
will get assigned every functionality!
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@1812 7894878c-1315-0410-8ee3-d5d059ff63e0
Mark D. Studebaker