mirror of
https://github.com/troglobit/finit.git
synced 2026-10-16 10:39:35 +00:00
fnwrite(): fix resource leak, found by Coverity Scan
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This commit is contained in:
1 parent
73629944c0
commit
3de9643893
1 file changed
+7
-4
+7
-4
@@ -89,6 +89,7 @@ int fnwrite(char *value, char *fmt, ...)
|
||||
char path[256];
|
||||
va_list ap;
|
||||
FILE *fp;
|
||||
int rc;
|
||||
|
||||
if (!value) {
|
||||
errno = EINVAL;
|
||||
@@ -105,11 +106,13 @@ int fnwrite(char *value, char *fmt, ...)
|
||||
|
||||
/* echo(1) always adds a newline */
|
||||
if (fputs(value, fp) == EOF ||
|
||||
fputs("\n", fp) == EOF ||
|
||||
fclose(fp))
|
||||
return -1;
|
||||
fputs("\n", fp) == EOF ||
|
||||
fclose(fp) == EOF)
|
||||
rc = -1;
|
||||
else
|
||||
rc = 0;
|
||||
|
||||
return 0;
|
||||
return rc;
|
||||
}
|
||||
|
||||
/*
|
||||
|
||||
Reference in new issue
Block a user